-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Share settings not persisted on new shares #44131
Labels
Comments
Fenn-CS
added
bug
0. Needs triage
Pending check for reproducibility or if it fits our roadmap
labels
Mar 11, 2024
Todo : Align with Louis to add cypress test once this is fixed. |
This is reproducible with 27 as well |
ChristophWurst
added
1. to develop
Accepted and waiting to be taken care of
and removed
0. Needs triage
Pending check for reproducibility or if it fits our roadmap
labels
Mar 25, 2024
ChristophWurst
added
2. developing
Work in progress
and removed
1. to develop
Accepted and waiting to be taken care of
labels
Mar 26, 2024
Fenn-CS
added a commit
that referenced
this issue
Mar 26, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
added a commit
that referenced
this issue
Mar 26, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
added a commit
that referenced
this issue
Mar 26, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
backportbot bot
pushed a commit
that referenced
this issue
Mar 26, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> [skip ci]
backportbot bot
pushed a commit
that referenced
this issue
Mar 26, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> [skip ci]
Fenn-CS
added a commit
that referenced
this issue
Mar 27, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
added a commit
that referenced
this issue
Mar 27, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
emoral435
pushed a commit
that referenced
this issue
Mar 29, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Fenn-CS
added a commit
that referenced
this issue
Mar 29, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
susnux
pushed a commit
that referenced
this issue
Mar 29, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Fenn-CS
added a commit
that referenced
this issue
Mar 29, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
emoral435
pushed a commit
that referenced
this issue
Apr 1, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: Eduardo Morales <emoral435@gmail.com>
emoral435
pushed a commit
that referenced
this issue
Apr 1, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
added a commit
that referenced
this issue
Apr 15, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
added a commit
that referenced
this issue
Apr 26, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Fenn-CS
added a commit
that referenced
this issue
Apr 26, 2024
- Send correct share attributes (`share.attributes`) to server upon creation. - Delete parts of code that create or reference, `share.hasDownloadPermission` (Not required by Share API) Resolves : #44131 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
Sometimes (depending on the options) items set while creating a new share won't be respected and the share would be created with a different set of defaults.
Steps to reproduce
Screencast
Peek.11-03-2024.15-46.mp4
Expected behavior
New share should be created with whatever settings the user sets upon creation
Installation method
None
Nextcloud Server version
master
Operating system
None
PHP engine version
None
Web server
None
Database engine version
None
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
Configuration report
No response
List of activated Apps
No response
Nextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
No response
The text was updated successfully, but these errors were encountered: