New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Share settings not persisted on new shares #44131

Closed

4 of 8 tasks

Fenn-CS opened this issue Mar 11, 2024 · 2 comments · Fixed by #44484

Closed

4 of 8 tasks

[Bug]: Share settings not persisted on new shares #44131

Fenn-CS opened this issue Mar 11, 2024 · 2 comments · Fixed by #44484

Assignees

Labels

2. developing 27-feedback 29-feedback bug feature: sharing

Contributor

Fenn-CS commented Mar 11, 2024

⚠️ This issue respects the following points: ⚠️

This is a bug, not a question or a configuration/webserver/proxy issue.
This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
I agree to follow Nextcloud's Code of Conduct.

Bug description

Sometimes (depending on the options) items set while creating a new share won't be respected and the share would be created with a different set of defaults.

Steps to reproduce

Screencast

Visit share menu on particular file and select user to share with
Uncheck allow downloads
Set custom permission (allow re-sharing)

Peek.11-03-2024.15-46.mp4

Expected behavior

New share should be created with whatever settings the user sets upon creation

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Default user-backend (database)
LDAP/ Active Directory
SSO - SAML
Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

Fenn-CS added bug 0. Needs triage labels

szaimen added the 29-feedback label

Contributor Author

Fenn-CS commented Mar 11, 2024

Todo :

Align with Louis to add cypress test once this is fixed.

Fenn-CS self-assigned this

ChristophWurst added the 27-feedback label

Member

ChristophWurst commented Mar 25, 2024

This is reproducible with 27 as well

ChristophWurst added 1. to develop and removed 0. Needs triage labels

joshtrichards added the feature: sharing label

ChristophWurst added 2. developing and removed 1. to develop labels

Fenn-CS added a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

b39487f

- Send correct share attributes (`share.attributes`) to server upon creation.
- Delete parts of code that create or reference, `share.hasDownloadPermission`
(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Fenn-CS mentioned this issue

fix(share): Send correct share attributes upon share creation #44484

Merged

Fenn-CS added a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

27205b0

- Send correct share attributes (`share.attributes`) to server upon creation.
- Delete parts of code that create or reference, `share.hasDownloadPermission`
(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Fenn-CS added a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

3a5475b

- Send correct share attributes (`share.attributes`) to server upon creation.
- Delete parts of code that create or reference, `share.hasDownloadPermission`
(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Fenn-CS closed this as completed in #44484

backportbot bot pushed a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

24f0d3e

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]

backportbot bot pushed a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

ad6597f

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]

Fenn-CS added a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

96066d1

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Fenn-CS added a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

2ac47d0

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

emoral435 pushed a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

63d2f7e

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>

Fenn-CS added a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

09e428a

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

susnux pushed a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

94d946c

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>

Fenn-CS added a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

f179349

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

emoral435 pushed a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

716af66

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>

emoral435 pushed a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

f8f60f6

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Fenn-CS added a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

58db30d

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

Fenn-CS added a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

8e97c6d

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>

Fenn-CS added a commit that referenced this issue


          fix(share): Send correct share attributes upon share creation

bbb28fd

- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment