Make individual app boot methods more lazy

[juliushaertl]

While looking at some flamegraphs I noticed that we still have plenty of apps that have logic in the boot method that could be done far more lazy. Those would trigger larger chunks of dependency injection pulling in class instances that might not be needed (yet). While some dependencies might still be pulled in later there is definitiely potential for saving some load in the app boot process.

While every change itself might be rather small, this could add up in total to become a nice improvement.

A few examples that could be beneficial to move:

• Mount provider registration (files_sharing, files_external, groupfolders, collectives, ...)
  • chore: Add event to register mount providers more lazy #45953
  • groupfolders
  • collectives
  • circles
  • files_external
• Some apps like files_sharing still register events in a non-lazy way
  • perf(files_sharing): Move events to listener classes and registration instead of boot #44967
• dav app hook manager pulls in lots of dependencies (

  server/apps/dav/lib/AppInfo/Application.php

  Line 222 in 443b267

  $context->injectFn([$this, 'registerHooks']);

  )
• Federation providers with addCloudFederationProvider (spreed, federatedfilesharing)
• Legacy resource provider (deck/talk) is not done fully lazy
• Share provider registration requires to setup the ShareManager (currently only relevant for deck as talk is hard coded in server)
• Comments event handler registration requires to pull in ICommentsManager

  server/apps/comments/lib/AppInfo/Application.php

  Line 86 in aa5f037

  $container->get(ICommentsManager::class)->registerEventHandler(function (): EventHandler {

  • chore: Move comments event handler to use proper event dispatcher #45951
  • chore: Move comments event handler to use proper event dispatcher deck#6008
• Legacy ISearch provider registration (could be dropped)
  • chore: Remove deprecated legacy search backend #45950
• files_lock registering lock provider (while ILockManager is free of dependencies, LockProvider has quite some that might be not needed on every request)
  • perf(ILockManager): Allow registering a lock provider lazy #44953
  • perf(boot): Initialize storage wrapper and lock manager more lazy files_lock#297
• Register template creators (text/richdocuments/onlyoffice)
  • perf(templates): Emit RegisterTemplateCreatorEvent to register template creators more lazy #44952
  • perf(bootstrap): Lazy register template creator through event text#5717
  • perf(bootstrap): Lazy register template creator through event richdocuments#3614