perf(files_sharing): Move events to listener classes and registration instead of boot #44967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
requested review from
nickvergessen,
a team,
ArtificialOwl,
yemkareems and
sorbaugh
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
16 tasks
juliushaertl
force-pushed
the
perf/sharing-events
branch
from
f1cc2ad
to
0c94893
Compare
nickvergessen
approved these changes
Apr 24, 2024
juliushaertl
force-pushed
the
perf/sharing-events
branch
from
0c94893
to
ea5b934
Compare
… instead of boot Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
perf/sharing-events
branch
from
ea5b934
to
0ca5c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is no need to register event listeners in boot, instead they can be moved to the register method to be more lazy. For the two listeners that were pulling in dependencies (IRootFolder, IUserSession) those can be moved to dedicated listeners, so DI will only initialize those dependencies when actually needed.
There is still some stuff left that could be migrated separately (will require additional API changes for the mount providers for example), but those are the obvious and easy ones.
Checklist