Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Disabled user's shared calendar still visible #45479

Open
5 of 8 tasks
fcharlaix-opendsi opened this issue May 23, 2024 · 1 comment
Open
5 of 8 tasks

[Bug]: Disabled user's shared calendar still visible #45479

fcharlaix-opendsi opened this issue May 23, 2024 · 1 comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug feature: caldav Related to CalDAV internals

Comments

@fcharlaix-opendsi
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

Disabled user's shared calendar are still visible in the calendar app and the CalDav

Steps to reproduce

  1. Create two users, user1 (admin) and user2
  2. user2 share a calendar with user1
  3. user1 disable user2

Expected behavior

user2 calendar isn't available in the calendar app or the CalDav.

Installation method

Community Docker image

Nextcloud Server version

29

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

SQlite

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "htaccess.RewriteBase": "\/",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "nextcloud"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "sqlite3",
        "version": "29.0.0.19",
        "overwrite.cli.url": "http:\/\/nextcloud",
        "installed": true,
        "maintenance": false,
        "loglevel": 2
    }
}

List of activated Apps

Enabled:
  - activity: 2.21.1
  - calendar: 4.7.4
  - circles: 29.0.0-dev
  - cloud_federation_api: 1.12.0
  - comments: 1.19.0
  - contacts: 6.0.0
  - contactsinteraction: 1.10.0
  - dashboard: 7.9.0
  - dav: 1.30.1
  - deck: 1.13.0
  - external: 5.4.0
  - federatedfilesharing: 1.19.0
  - federation: 1.19.0
  - files: 2.1.0
  - files_antivirus: 5.5.2
  - files_downloadlimit: 2.0.0
  - files_pdfviewer: 2.10.0
  - files_reminders: 1.2.0
  - files_sharing: 1.21.0
  - files_trashbin: 1.19.0
  - files_versions: 1.22.0
  - firstrunwizard: 2.18.0
  - forms: 4.2.3
  - impersonate: 1.16.0
  - logreader: 2.14.0
  - lookup_server_connector: 1.17.0
  - nextcloud_announcements: 1.18.0
  - notifications: 2.17.0
  - oauth2: 1.17.0
  - password_policy: 1.19.0
  - photos: 2.5.0
  - polls: 7.0.3
  - privacy: 1.13.0
  - provisioning_api: 1.19.0
  - recommendations: 2.1.0
  - related_resources: 1.4.0
  - serverinfo: 1.19.0
  - settings: 1.12.0
  - sharebymail: 1.19.0
  - support: 1.12.0
  - survey_client: 1.17.0
  - systemtags: 1.19.0
  - tables: 0.7.2
  - text: 3.10.0
  - theming: 2.4.0
  - twofactor_backupcodes: 1.18.0
  - updatenotification: 1.19.1
  - user_oidc: 5.0.2
  - user_status: 1.9.0
  - viewer: 2.3.0
  - weather_status: 1.9.0
  - workflowengine: 2.11.0
Disabled:
  - admin_audit: 1.19.0
  - bruteforcesettings: 2.9.0
  - encryption: 2.17.0
  - files_external: 1.21.0
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - suspicious_login: 7.0.0
  - timemanager: 0.3.14 (installed 0.3.14)
  - twofactor_totp: 11.0.0-dev
  - user_ldap: 1.20.0
  - user_saml: 6.1.3 (installed 6.1.3)

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

{"reqId":"QCMePYoYZ0VAR0w0K1KD","level":3,"time":"2024-05-21T13:03:19+00:00","remoteAddr":"172.21.0.1","user":"--","app":"PHP","method":"GET","url":"/strings/Brother_MFC-9330CDW.strings","message":"Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter at /var/www/html/custom_apps/deck/lib/Service/ConfigService.php#234","userAgent":"CUPS/2.4.8 (Linux 6.9.1-arch1-1; x86_64) IPP/2.0","version":"29.0.0.19","data":{"app":"PHP"}}
{"reqId":"YwSveQSeS4aGzmiYjHgq","level":3,"time":"2024-05-23T12:48:49+00:00","remoteAddr":"172.21.0.1","user":"fcharlaix","app":"PHP","method":"GET","url":"/","message":"Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter at /var/www/html/custom_apps/deck/lib/Service/ConfigService.php#234","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:126.0) Gecko/20100101 Firefox/126.0","version":"29.0.0.19","data":{"app":"PHP"}}
{"reqId":"k2nn39DofXrdP3CfCTAz","level":3,"time":"2024-05-23T12:51:27+00:00","remoteAddr":"172.21.0.1","user":"fcharlaix","app":"PHP","method":"GET","url":"/ocs/v2.php/apps/notifications/api/v2/notifications","message":"Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter at /var/www/html/custom_apps/deck/lib/Service/ConfigService.php#234","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:126.0) Gecko/20100101 Firefox/126.0","version":"29.0.0.19","data":{"app":"PHP"}}
{"reqId":"Hd34b175OIrmwt3UAELW","level":2,"time":"2024-05-23T12:52:03+00:00","remoteAddr":"172.21.0.1","user":"fcharlaix","app":"no app in context","method":"GET","url":"/ocs/v2.php/cloud/users/details?offset=0&limit=25&search=","message":"Transaction took 1.2306659221649s","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:126.0) Gecko/20100101 Firefox/126.0","version":"29.0.0.19","exception":{"Exception":"Exception","Message":"Transaction took 1.2306659221649s","Code":0,"Trace":[{"file":"/var/www/html/lib/private/DB/ConnectionAdapter.php","line":154,"function":"commit","class":"OC\\DB\\Connection","type":"->","args":[]},{"file":"/var/www/html/lib/private/Files/Config/UserMountCache.php","line":143,"function":"commit","class":"OC\\DB\\ConnectionAdapter","type":"->","args":[]},{"file":"/var/www/html/lib/private/Files/SetupManager.php","line":299,"function":"registerMounts","class":"OC\\Files\\Config\\UserMountCache","type":"->","args":[["OC\\User\\User"],[["OC\\Files\\Mount\\HomeMountPoint"]],["OC\\Files\\Mount\\CacheMountProvider","OCA\\Files_Sharing\\MountProvider","OCA\\Files_Sharing\\External\\MountProvider"]]},{"file":"/var/www/html/lib/private/Files/SetupManager.php","line":223,"function":"afterUserFullySetup","class":"OC\\Files\\SetupManager","type":"->","args":[["OC\\User\\User"],[]]},{"file":"/var/www/html/lib/private/legacy/OC_Util.php","line":111,"function":"setupForUser","class":"OC\\Files\\SetupManager","type":"->","args":[["OC\\User\\User"]]},{"file":"/var/www/html/apps/provisioning_api/lib/Controller/AUserData.php","line":261,"function":"setupFS","class":"OC_Util","type":"::","args":["fcharlaix"]},{"file":"/var/www/html/apps/provisioning_api/lib/Controller/AUserData.php","line":159,"function":"fillStorageInfo","class":"OCA\\Provisioning_API\\Controller\\AUserData","type":"->","args":["fcharlaix"]},{"file":"/var/www/html/apps/provisioning_api/lib/Controller/UsersController.php","line":199,"function":"getUserData","class":"OCA\\Provisioning_API\\Controller\\AUserData","type":"->","args":["fcharlaix"]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":232,"function":"getUsersDetails","class":"OCA\\Provisioning_API\\Controller\\UsersController","type":"->","args":["",25,0]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":138,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Provisioning_API\\Controller\\UsersController"],"getUsersDetails"]},{"file":"/var/www/html/lib/private/AppFramework/App.php","line":184,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Provisioning_API\\Controller\\UsersController"],"getUsersDetails"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":338,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Provisioning_API\\Controller\\UsersController","getUsersDetails",["OC\\AppFramework\\DependencyInjection\\DIContainer"],["ocs.provisioning_api.users.getusersdetails"]]},{"file":"/var/www/html/ocs/v1.php","line":66,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/ocsapp/cloud/users/details"]},{"file":"/var/www/html/ocs/v2.php","line":23,"args":["/var/www/html/ocs/v1.php"],"function":"require_once"}],"File":"/var/www/html/lib/private/DB/Connection.php","Line":691,"message":"Transaction took 1.2306659221649s","exception":{},"CustomMessage":"Transaction took 1.2306659221649s"}}

Additional info

This also works with group share (and is the main reason why I have created this issue)

@fcharlaix-opendsi fcharlaix-opendsi added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels May 23, 2024
@solracsf solracsf added 29-feedback feature: caldav Related to CalDAV internals labels May 23, 2024
@mhzawadi
Copy link

can confirm this, have updated from v28 to v29 and now get this error with every run of the cron.php

PHP Deprecated:  Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter in /srv/www/horwood-nextcloud/apps/deck/lib/Service/ConfigService.php on line 234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug feature: caldav Related to CalDAV internals
Projects
None yet
Development

No branches or pull requests

3 participants