Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use png for logo in email header #4647

Closed
LukasReschke opened this issue May 1, 2017 · 4 comments
Closed

Use png for logo in email header #4647

LukasReschke opened this issue May 1, 2017 · 4 comments

Comments

@LukasReschke
Copy link
Member

Gmail and Inbox do neither on web nor native support SVG images. We need thus to use a regular image in our emails.

@LukasReschke LukasReschke added this to the Nextcloud 12.0 milestone May 1, 2017
@LukasReschke
Copy link
Member Author

The link is generated by calling \OCA\Theming\ThemingDefaults::getLogo in \OC\Mail\EMailTemplate::addHeader. So I suppose we either add a parameter like $svg = true to getLogo or we add another function. Opinions?

@jancborchardt
Copy link
Member

Yeah, just getLogo I guess? We previously used a gif for the emails so it worked on all platforms. Was it removed because that’s not necessary anymore, by checking on caniuse.com or so? cc @Espina2 @MorrisJobke

@MorrisJobke
Copy link
Member

MorrisJobke commented May 2, 2017

Yeah, just getLogo I guess? We previously used a gif for the emails so it worked on all platforms. Was it removed because that’s not necessary anymore, by checking on caniuse.com or so? cc @Espina2 @MorrisJobke

I guess it was removed due to "we want to use the theming logo". Which is sometimes an SVG, sometimes a PNG and sometimes a JPG.

by checking on caniuse.com or so?

This doesn't work, because this highly depend on the email provider. Gmail does other sanitising than outlook than web.de, than ... :/ That's the general problem with emails. And also the reason why we use a massive amount of <table> ... something like 20-30 per email.

LukasReschke added a commit that referenced this issue May 8, 2017
Fixes #4647

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@michag86
Copy link
Contributor

michag86 commented Mar 2, 2018

This is only working with default logo. If you use custom logo (svg) set by theming app, this is not working.
Is there a way to get this working?
cc @MorrisJobke @LukasReschke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants