Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Need context for placeholders #46632

Closed
rakekniven opened this issue Jul 19, 2024 · 3 comments · Fixed by #46661
Closed

i18n: Need context for placeholders #46632

rakekniven opened this issue Jul 19, 2024 · 3 comments · Fixed by #46661
Assignees
Labels
1. to develop Accepted and waiting to be taken care of feature: language l10n and translations

Comments

@rakekniven
Copy link
Member

[true, true] => $this->l10n->t('In %1$s %2$s on %3$s between %4$s - %5$s', [$occuring[0], $occuring[1], $startDate, $startTime, $endTime]),

Please add comments for the translators to the source code explaining the placeholders.

Same for other strings having many placeholders.

@SebastianKrupinski github blame brought me to you.

@SebastianKrupinski SebastianKrupinski self-assigned this Jul 19, 2024
@SebastianKrupinski
Copy link
Contributor

Good Morning,

Yes those are changes I made. I will make those comments this weekend.

@rakekniven
Copy link
Member Author

@SebastianKrupinski
Copy link
Contributor

@rakekniven please have a look at the PR and let me know if that is what you are looking for and whether its too much or not enough information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of feature: language l10n and translations
Projects
Development

Successfully merging a pull request may close this issue.

3 participants