New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bearer auth backend causes problems with several dav clients #5088

Closed
nickvergessen opened this Issue May 24, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@nickvergessen
Member

nickvergessen commented May 24, 2017

The topic is getting way too much replies:
https://help.nextcloud.com/t/nc12-authentication-issue-with-cardav-caldav-and-sogo-connector/12924/

We need to find a way for this, so it doesn't break all the clients anymore.

cc @LukasReschke

@GieltjE

This comment has been minimized.

Show comment
Hide comment
@GieltjE

GieltjE May 25, 2017

#5092 Appears to be a duplicate or at least directly related.

GieltjE commented May 25, 2017

#5092 Appears to be a duplicate or at least directly related.

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen May 25, 2017

Member

Yeah, see the link to the forum above for a temporary workaround

Member

nickvergessen commented May 25, 2017

Yeah, see the link to the forum above for a temporary workaround

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke May 25, 2017

Member

Does reordering the auth mechanisms help or should we do something REALLY hacky and prevent the second Authenticate header?

Note that this really is more of a bug in the clients… but well, if apparently all clients implement such stuff incorrectly 🙈

I think the hacky approach might help us more :)

Member

LukasReschke commented May 25, 2017

Does reordering the auth mechanisms help or should we do something REALLY hacky and prevent the second Authenticate header?

Note that this really is more of a bug in the clients… but well, if apparently all clients implement such stuff incorrectly 🙈

I think the hacky approach might help us more :)

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen May 26, 2017

Member

Reordering doesn't seem to help, because the order is different on the dav/ endpoint, but many people also have problems on that one.

Member

nickvergessen commented May 26, 2017

Reordering doesn't seem to help, because the order is different on the dav/ endpoint, but many people also have problems on that one.

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke May 26, 2017

Member

K, we'll then just pretend to only do Basic Auth 🙈

Member

LukasReschke commented May 26, 2017

K, we'll then just pretend to only do Basic Auth 🙈

@Aehrraid

This comment has been minimized.

Show comment
Hide comment
@Aehrraid

Aehrraid May 31, 2017

Thanks for bringing this in 12.0.1. When will this be released? Where can I find a release-plan for minor updates? The topic is quite important for me.
I found https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule and https://github.com/nextcloud/server/milestone/25 but those didn't help a lot.

Aehrraid commented May 31, 2017

Thanks for bringing this in 12.0.1. When will this be released? Where can I find a release-plan for minor updates? The topic is quite important for me.
I found https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule and https://github.com/nextcloud/server/milestone/25 but those didn't help a lot.

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen May 31, 2017

Member

@Aehrraid you can also just fix it manually right now with:
https://help.nextcloud.com/t/nc12-authentication-issue-with-cardav-caldav-and-sogo-connector/12924/9

the "average" release cycle is 4weeks

Member

nickvergessen commented May 31, 2017

@Aehrraid you can also just fix it manually right now with:
https://help.nextcloud.com/t/nc12-authentication-issue-with-cardav-caldav-and-sogo-connector/12924/9

the "average" release cycle is 4weeks

LukasReschke added a commit that referenced this issue Jun 13, 2017

Prevent sending second WWW-Authenticate header
Overrides \Sabre\DAV\Auth\Backend\AbstractBearer::challenge to prevent sending a second WWW-Authenticate header which is standard-compliant but most DAV clients simply fail hard.

Fixes #5088

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

LukasReschke added a commit that referenced this issue Jun 13, 2017

Prevent sending second WWW-Authenticate header
Overrides \Sabre\DAV\Auth\Backend\AbstractBearer::challenge to prevent sending a second WWW-Authenticate header which is standard-compliant but most DAV clients simply fail hard.

Fixes #5088

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

LukasReschke added a commit that referenced this issue Jun 13, 2017

Prevent sending second WWW-Authenticate header
Overrides \Sabre\DAV\Auth\Backend\AbstractBearer::challenge to prevent sending a second WWW-Authenticate header which is standard-compliant but most DAV clients simply fail hard.

Fixes #5088

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment