-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly replace open graph favicon #5322
Comments
Fixes #5322 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Fixes #5322 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@MorrisJobke I'd like favicon-fb.png to be overridden by the favicon specified in the Theming app. It's not currently the case (as of 15.0.2). Who should I talk to about that and how can I help? Thanks! |
@JaredBoone Could you also open a separate ticket for this. It seems the old icon is used there as well for untamed instances. |
@JaredBoone Yes, please open a new ticket for this. If you want to look into fixing this, the relevant code part where the icons are replaced is here: https://github.com/nextcloud/server/blob/master/apps/theming/lib/ThemingDefaults.php#L337-L342 |
server/apps/files_sharing/lib/Controller/ShareController.php
Lines 375 to 380 in ad24b86
We should probably use
\OCA\Theming\Controller\IconController::getTouchIcon
here if available.The text was updated successfully, but these errors were encountered: