Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags icon is too bright #626

Closed
MariusBluem opened this issue Jul 28, 2016 · 10 comments
Closed

Tags icon is too bright #626

MariusBluem opened this issue Jul 28, 2016 · 10 comments
Assignees
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: tags good first issue Small tasks with clear documentation about how and in which place you need to fix things in. medium

Comments

@MariusBluem
Copy link
Member

To solve #232, #311 introduced a new icon for the tags app (which is very nice). The problem is, that the color is still not matching with the other icons in the sidebar 😁 The grey is too bright.

tags_icon_export

@jancborchardt @Bugsbane @nextcloud/designers

@MariusBluem MariusBluem added this to the Nextcloud 10.0 milestone Jul 28, 2016
@jancborchardt
Copy link
Member

Ah – that’s because it should be black instead of grey :) The greying is handled via CSS. Can you change that @Bugsbane?

@jancborchardt jancborchardt added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Jul 28, 2016
@MariusBluem MariusBluem added the 1. to develop Accepted and waiting to be taken care of label Jul 28, 2016
@Bugsbane
Copy link
Member

Bugsbane commented Aug 7, 2016

I'd already adjusted the icon to a black, optimized version in my own repo, but I've also made a number of unfinished changes on my repo for another issue, so I'm not entirely sure how to do a pull request via Github just for that one file change, and not the others.

Anyone's welcome to commit the file at https://github.com/Bugsbane/server/blob/master/apps/files/img/recent.svg though

@MariusBluem
Copy link
Member Author

@Bugsbane I will cherry-pick your commit to another branch on my fork 😉 For the future: Fix unrelated bugs in seperate branches, so that you can commit them seperate.

@MariusBluem
Copy link
Member Author

Damn... We are talking about tags here and not about recent-file listing 😁 @Bugsbane
Did I missed anything. Closed the PR because of this 😢

@Bugsbane
Copy link
Member

Bugsbane commented Aug 7, 2016

Ah, sorry! I was working on both icons and got mixed up. Cherry pick these commits for a black version of the tag icon (SVG and PNG):
Bugsbane@f56e586
Bugsbane@b41c4aa

@MariusBluem
Copy link
Member Author

@Bugsbane THX. Please check this again. Do we need the png. Should it not be 16x16.

@Bugsbane
Copy link
Member

Bugsbane commented Aug 8, 2016

sigh Clearly I should be sleeping instead of committing! Yes it should be 16x16px. My understanding is that the PNG's are used as a fallback on older IE's that don't support SVG. Not sure if that's still relevant, though. Anyway, here's the 16x16px version:
Bugsbane@0b502af

@MariusBluem
Copy link
Member Author

MariusBluem commented Aug 8, 2016

@Bugsbane May I ask you to make your commit (png and svg replacing) to this branch: fix-tags-icon 👊

@Bugsbane
Copy link
Member

Bugsbane commented Aug 8, 2016

Sorry, I'm still pretty new to Git and getting distracted by finding my way around. The individual commit is at 9a9b782 and included in PR #764

@MariusBluem MariusBluem added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Aug 8, 2016
@MariusBluem
Copy link
Member Author

Fixed by #764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: tags good first issue Small tasks with clear documentation about how and in which place you need to fix things in. medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants