Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black version of system tags icon #764

Merged
merged 1 commit into from
Aug 8, 2016
Merged

Add black version of system tags icon #764

merged 1 commit into from
Aug 8, 2016

Conversation

Bugsbane
Copy link
Member

@Bugsbane Bugsbane commented Aug 8, 2016

Includes PNG (16x16px) and SVG (scoured) versions in black, to be uniform with the other icon files. Addresses #626 (comment)

Includes PNG (16x16px) and SVG (scoured) versions in black, to be uniform with the other icon files.
@mention-bot
Copy link

@Bugsbane, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81 to be a potential reviewer

@Bugsbane Bugsbane mentioned this pull request Aug 8, 2016
@blizzz blizzz added the design Design, UI, UX, etc. label Aug 8, 2016
@blizzz
Copy link
Member

blizzz commented Aug 8, 2016

@nextcloud/designers

@MariusBluem
Copy link
Member

This fixes #626 - Backport to Nextcloud 10 requested 😉

cc @karlitschek

@MariusBluem MariusBluem added this to the Nextcloud 11.0 milestone Aug 8, 2016
@karlitschek
Copy link
Member

Awesome!! Please backport :-)

@MariusBluem
Copy link
Member

👍

@rullzer
Copy link
Member

rullzer commented Aug 8, 2016

For NC 11 we can do only SVG if I'm not mistaken.

@MariusBluem
Copy link
Member

Thats correct but this is also not done at the other apps. Would be nice if we could have a statement from @jancborchardt 😉

@rullzer
Copy link
Member

rullzer commented Aug 8, 2016

👍

@MariusBluem
Copy link
Member

I will merge this now, as it fixes the problem. I will backport this to Nextcloud 10 💪
...removing the .png for Nextcloud 11 can be done via a bulk remove of all .png's of the other apps and all other components. For now, it is important to get this fixed in Nextcloud 10 😉

@jancborchardt
Copy link
Member

Thanks a lot @Bugsbane! :)

@Bugsbane
Copy link
Member Author

No problem. Happy to help. :)

GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this pull request Aug 30, 2016
Add black version of system tags icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. feature: tags
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants