Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add occ commands to pregenerate CSS and JS files #7984

Closed
rullzer opened this issue Jan 22, 2018 · 11 comments
Closed

Add occ commands to pregenerate CSS and JS files #7984

rullzer opened this issue Jan 22, 2018 · 11 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: caching Related to our caching system: scssCacher, jsCombiner... feature: scss

Comments

@rullzer
Copy link
Member

rullzer commented Jan 22, 2018

Just so it doesn't have to happen on demand.

As an added bonus we could add a '--rebuild' flag or something. So that if people somehow mess up their files in the appdata dir. That we just regenerate everything.

@skjnldsv does this make sense to you?

@skjnldsv
Copy link
Member

So we could have a fix to give to users who have a broken setup?

@juliushaertl
Copy link
Member

Makes sense to have, basically this is what is left in #6587.

@juliushaertl juliushaertl added 1. to develop Accepted and waiting to be taken care of feature: scss labels Jan 26, 2018
@juliushaertl
Copy link
Member

We should also fore rebuild during upgrade when implementing this.

@juliushaertl
Copy link
Member

PR to clear the caches during update / occ maintenance:repair is in #7984

@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Feb 1, 2018
@skjnldsv skjnldsv added the feature: caching Related to our caching system: scssCacher, jsCombiner... label May 3, 2018
@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@MorrisJobke
Copy link
Member

@juliushaertl Something for the polishing phase or should we just drop this in favor of the idea to not generate it during runtime, but during build time?

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jul 3, 2018
@rullzer
Copy link
Member Author

rullzer commented Jul 3, 2018

So JS will be generated at build time for all the vue apps. That would cover most of it at some point.

@juliushaertl
Copy link
Member

We could do that for core scss/js but we cannot easily determine what files apps use for their styles or scripts and need to do it at runtime. At least with our current API.

@MorrisJobke
Copy link
Member

Most likely nothing for 14 -> moving to 15.

@rullzer rullzer removed this from the Nextcloud 15 milestone Nov 5, 2018
@DanScharon
Copy link

is this still being worked on? Integrating this into occ maintenance:repair is overkill for us as it puts the instance into maintenance mode when we just want to regenerate CSS and JS files

@MorrisJobke
Copy link
Member

I guess nobody is working on this. We also will not have the dynamic SCSS generation on the instances itself that long anymore. It is planned to be moved into the build process once we can remove the IE compatibility, which we will deprecated in Nextcloud 20 and most likely 2-3 releases later. Then we can use CSS variables and this whole problem is not anymore.

@nickvergessen
Copy link
Member

SCSS cacher has been removed and JS+CSS are compiled in the package now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: caching Related to our caching system: scssCacher, jsCombiner... feature: scss
Projects
None yet
Development

No branches or pull requests

7 participants