Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle users with numeric user ids #10161

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Correctly handle users with numeric user ids #10161

merged 1 commit into from
Jul 9, 2018

Conversation

nickvergessen
Copy link
Member

First user is lacking their numeric id:

Before

  - OneTwo
  - admin: admin
  - test1: Seattle Seahawks
  - test2: New Orleans Saints
  - test3: Pittsburgh Steelers
  - test4: Atlanta Falcons
  - test5: Jacksonville Jaguars

After

  - 123456: OneTwo
  - admin: admin
  - test1: Seattle Seahawks
  - test2: New Orleans Saints
  - test3: Pittsburgh Steelers
  - test4: Atlanta Falcons
  - test5: Jacksonville Jaguars

Fix #10158

@nickvergessen
Correctly handle users with numeric user ids
1ca075a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Jul 9, 2018
@nickvergessen nickvergessen mentioned this pull request Jul 9, 2018
Closed
MorrisJobke
MorrisJobke approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 9, 2018
@nickvergessen nickvergessen force-pushed the bugfix/10158/correctly-handle-users-with-numeric-user-ids branch from 5e402c4 to 1ca075a Compare July 9, 2018 13:37
@MorrisJobke MorrisJobke merged commit 6afb8af into master Jul 9, 2018
@MorrisJobke MorrisJobke deleted the bugfix/10158/correctly-handle-users-with-numeric-user-ids branch July 9, 2018 13:38
@MorrisJobke MorrisJobke mentioned this pull request Jul 10, 2018
Merged
@MorrisJobke
Copy link
Member

Let me do the backport.

@MorrisJobke MorrisJobke mentioned this pull request Jul 11, 2018
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickvergessen @MorrisJobke @rullzer