Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all sidebar entries have the "classes" attribute #10406

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Not all sidebar entries have the "classes" attribute #10406

merged 1 commit into from
Jul 26, 2018

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Jul 26, 2018 •
edited
Loading

Fixes #10405

@MorrisJobke
Not all sidebar entries have the "classes" attribute
68ba96a 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Jul 26, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Jul 26, 2018
@MorrisJobke MorrisJobke mentioned this pull request Jul 26, 2018
Closed
rullzer
rullzer approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 26, 2018
@MorrisJobke MorrisJobke merged commit 6514bf1 into master Jul 26, 2018
@MorrisJobke MorrisJobke deleted the bugfix/10405/undefined-index-classes branch July 26, 2018 14:05
@MorrisJobke MorrisJobke mentioned this pull request Jul 26, 2018
Closed
51 tasks
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@newhinton newhinton Awaiting requested review from newhinton

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MorrisJobke @rullzer @juliushaertl