Disable Oracle enforcement for now until the following issues are sol… #10553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved: * Only apps should be checked which say they support oracle * Only check newly added items, to allow forward migration from an existing database structure Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
rullzer,
icewind1991,
ChristophWurst,
blizzz and
juliushaertl
rullzer
approved these changes
Aug 6, 2018
icewind1991
approved these changes
Aug 6, 2018
|
CI not happy |
|
Thanks for fixing the test, was about to do that now, but well #relax |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ved:
Ref #10518
Not closing the ticket because we should look into fixing it, instead of commenting out.
I will do that, but maybe not for 14.