Only enforce schema limits for supported apps #10555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested review from
rullzer,
icewind1991,
ChristophWurst,
blizzz and
juliushaertl
rullzer
reviewed
Aug 6, 2018
| $infoParser = new InfoParser(); | ||
| $info = $infoParser->parse($appPath . '/appinfo/info.xml'); | ||
| if (!isset($info['dependencies']['database'])) { | ||
| $this->checkOracle = true; |
There was a problem hiding this comment.
so by default we check always check oracle?
There was a problem hiding this comment.
Yeah if the author did not define a db, you can install it on any. It a db is given the dependency check ensures it. So that mathes the logic here
|
Lets do this properly for 15 |
|
@nickvergessen Could you please rebase to fix the conflict? |
MorrisJobke
added
2. developing
|
Done, the "conflict" was f5c63d7 |
nickvergessen
force-pushed
the
bugfix/10518/only-check-added-items
branch
from
bba82f1
to
9af5d4c
Compare
nickvergessen
added
3. to review
MorrisJobke
approved these changes
Oct 9, 2018
|
Looks like some tests fail 🙈 |
nickvergessen
force-pushed
the
bugfix/10518/only-check-added-items
branch
from
9af5d4c
to
cc1253a
Compare
Resolved. |
|
@nickvergessen @rullzer Should we do this now or wait for 16? |
|
I'm always in favor of it. but well I manually cross check that oracle still works via the notifications tests… |
|
Let's move it to 16 and merge it early this time. |
|
#12446 🙈 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/10518/only-check-added-items
branch
from
cc1253a
to
85a0e10
Compare
|
Rebased to re-execuite the tests, please merge soonish |
blizzz
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10518