Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix this context for enter-key handler on app tokens #10582

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

ChristophWurst
Copy link
Member

Fixes https://sentry.io/share/issue/e07c5560b6154212832e4cd6598464c7/.

Steps to reproduce:

  1. Go to security settings page
  2. Focus app tokens input
  3. Press enter

Expected behavior

New token is generated.

Actual behavior

Nothing.

@rullzer rullzer added the 3. to review Waiting for reviews label Aug 8, 2018
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaaahh, Backbone! :')

@skjnldsv skjnldsv merged commit 3884038 into master Aug 8, 2018
Christoph's Tasks automation moved this from SELECTED to DONE Aug 8, 2018
@skjnldsv skjnldsv deleted the fix/app-password-enter-this-context branch August 8, 2018 10:38
@rullzer rullzer mentioned this pull request Aug 8, 2018
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants