Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use insertIfNotExists to store new mimetypes. #10618

Merged
merged 1 commit into from
Aug 10, 2018
Merged

use insertIfNotExists to store new mimetypes. #10618

merged 1 commit into from
Aug 10, 2018

Conversation

icewind1991
Copy link
Member

Also throw an error if we can't find the mimetype after insert

Hopefully makes it more robust

@icewind1991
use insertIfNotExists to store new mimetypes.
5e9d6b1 
Also throw an error if we can't find the mimetype after insert

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 2. developing Work in progress label Aug 9, 2018
@icewind1991 icewind1991 added this to the Nextcloud 14 milestone Aug 9, 2018
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 9, 2018
@icewind1991 icewind1991 mentioned this pull request Aug 9, 2018
Merged
@rullzer rullzer mentioned this pull request Aug 9, 2018
Closed
45 tasks
ChristophWurst
ChristophWurst approved these changes Aug 10, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense

@rullzer rullzer merged commit a080c42 into master Aug 10, 2018
@rullzer rullzer deleted the mimetype-insert-if-not-exists branch August 10, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icewind1991 @rullzer @ChristophWurst