Apply flex-basis to right header #10623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
added
bug
design
juliushaertl
requested review from
nickvergessen,
ChristophWurst,
weeman1337 and
skjnldsv
|
What if more apps add their menu in it? :) |
That is rather critical anyway since we are running out of space on mobile devices there. If i remember, we've discussed in the past that apps should not add icons there, so we didn't provide a public API for that. I'd say we can discuss that more in depth at the conference. 😉 This PR at least fixes the issue for all installations that don't have apps adding additional icons there. |
|
Yes, you're right, I remember! :) |
rullzer
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10452
Steps to reproduce:
This occurs only some times to me, but my guess is that the notifications icon is added after the menu calculation has been done. This PR just adds a flex-basis of 210px (which is the width of the .header-right container with all icons visible) so we have a hint on how big the container will be already before the notification icon was added.
Before:
After:
