Fix share dialog sidebar in share views #10700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCA.Sharing.SharedFileInfo was never defined and that stopped execution. Interestingly, FF never showed me an error. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
bug
3. to review
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/10516/sharepermissions
branch
from
402da0d
to
e89567e
Compare
|
unit tests are not happy https://drone.nextcloud.com/nextcloud/server/9669/259 |
skjnldsv
approved these changes
Aug 15, 2018
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
fixed |
|
@blizzz What about the backport? |
|
Thanks for the reminder. Will do, on my list. |
cough tomorrow is RC day cough |
This was referenced Aug 22, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was due to a change where permission are taken over from the DAV endpoint.
Also removes dead code which i reasonable to backport (first commit).