Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Resolve all group memberships properly #10783

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Aug 21, 2018

backport of #10775

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@blizzz blizzz added this to the Nextcloud 13.0.6 milestone Aug 21, 2018
@MorrisJobke MorrisJobke changed the title Resolve all group memberships properly [stable13] Resolve all group memberships properly Aug 21, 2018
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@MorrisJobke MorrisJobke mentioned this pull request Aug 22, 2018
8 tasks
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke merged commit 5bc7af2 into stable13 Aug 22, 2018
@MorrisJobke MorrisJobke deleted the backport/10775/stable13 branch August 22, 2018 08:51
@blizzz
Copy link
Member Author

blizzz commented Aug 22, 2018

🐘

affects scnenarios only when memberUid is used to assign users to groups which is least efficient. Essentially it contains a plain uid. Values read from LDAP are not trimmed by default by us. Usually we don't read out values where they would make sense, OTOH changing behaviour isn't good for backporting. In that particular case, trimming is fine and helps fetching the DN for the given uid.

@nextcloud-bot nextcloud-bot mentioned this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants