Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix design of 2FA login screens #11591

Merged
merged 1 commit into from Oct 3, 2018
Merged

Fix design of 2FA login screens #11591

merged 1 commit into from Oct 3, 2018

Conversation

ChristophWurst
Copy link
Member

  • Fix rending of empty selection screen (ul missing)
  • Fix rendering of backup codes inputs

Selection screen, before

bildschirmfoto von 2018-10-03 15-25-33

Selection screen, after

bildschirmfoto von 2018-10-03 15-25-49

Backup codes, before

bildschirmfoto von 2018-10-03 15-30-32

Backupcodes, after

bildschirmfoto von 2018-10-03 15-30-13

@ChristophWurst
Fix design of 2FA login screens
335a461 
* Fix rending of empty selection screen (ul missing)
* Fix rendering of backup codes inputs

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: authentication labels Oct 3, 2018
@ChristophWurst ChristophWurst added this to the Nextcloud 15 milestone Oct 3, 2018
@ChristophWurst ChristophWurst self-assigned this Oct 3, 2018
@ChristophWurst ChristophWurst added this to In progress in Mandatory 2FA via automation Oct 3, 2018
MorrisJobke
MorrisJobke approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

rullzer
rullzer approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 3, 2018
jancborchardt
jancborchardt approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@jancborchardt
Copy link
Member

For separate pull request:

  • Add lock icon to the initial page
  • Make sure "Use backup code" uses primary button class

@MorrisJobke MorrisJobke merged commit 80cc48b into master Oct 3, 2018
Mandatory 2FA automation moved this from In progress to Done Oct 3, 2018
@MorrisJobke MorrisJobke deleted the fix/2fa-login-screen-design branch October 3, 2018 15:40
@nextcloud-bot nextcloud-bot mentioned this pull request Nov 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: authentication
Projects
No open projects
Mandatory 2FA
  
Done
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChristophWurst @jancborchardt @rullzer @MorrisJobke