Rename admin security section #11671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
3. to review
ChristophWurst
added this to IN PROGRESS (max 3 PRs)
in Christoph's Tasks
via automation
ChristophWurst
requested review from
rullzer,
MorrisJobke,
nickvergessen and
blizzz
Christoph's Tasks
automation
moved this from IN PROGRESS (max 3 PRs)
to TO REVIEW (max 4 PRs)
Oct 8, 2018
rullzer
requested changes
Oct 8, 2018
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
refactor/rename-admin-security-section
branch
from
aef0478
to
5d2fdfe
Compare
rullzer
approved these changes
Oct 8, 2018
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
Unit tests fail 🙈 |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
Of course they do 🙈 |
MorrisJobke
added
4. to release
nickvergessen
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't find the security section class until I realized it was named encryption (for legacy reasons I suppose). This streamlines the naming with the other sections (esp with personal security settings).
Required for #11017.