Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14] Allow overwrite.cli.url without trailing slash #11772

Merged
merged 1 commit into from Oct 19, 2018
Merged

[14] Allow overwrite.cli.url without trailing slash #11772

merged 1 commit into from Oct 19, 2018

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 11, 2018

Backport #11446

@kesselb
Backport #11446
4f983b7 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb added the bug label Oct 11, 2018
@kesselb kesselb added this to the Nextcloud 14.0.3 milestone Oct 11, 2018
@kesselb kesselb changed the title Backport https://github.com/nextcloud/server/pull/11446 [14] Allow overwrite.cli.url without trailing slash Oct 11, 2018
@kesselb kesselb added the 3. to review Waiting for reviews label Oct 11, 2018
@juliushaertl
Copy link
Member

Failing tests seem unrelated

All postgres:

Error while trying to create admin user: Failed to connect to the database: An exception occured in driver: SQLSTATE[08006] [7] FATAL:  permission denied for database "oc_autotest"
DETAIL:  User does not have CONNECT privilege.

@MorrisJobke
Copy link
Member

All postgres:

Happens sometimes :/

@MorrisJobke MorrisJobke merged commit 2885db8 into stable14 Oct 19, 2018
@MorrisJobke MorrisJobke deleted the stable14-pretty-urls-dont-work branch October 19, 2018 10:16
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
Merged
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 14.0.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kesselb @juliushaertl @MorrisJobke