Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14] Allow userId to be null #11939

Merged
merged 1 commit into from Oct 19, 2018
Merged

[14] Allow userId to be null #11939

merged 1 commit into from Oct 19, 2018

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 19, 2018

Backport of #11611

Fixes #10852

A quick hack. Still ensures some type safety however now also accepts
null. Else we'd need to add a whole new layer of middlewares.

This can only happen when a guest user wants to access a controller that
requries the user_id.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer merged commit 76b3bbc into stable14 Oct 19, 2018
1 check failed
1 check failed
continuous-integration/drone/pr the build failed
Details
@rullzer rullzer deleted the backport/11611/stable14 branch Oct 19, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants