Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13] Reset bruteforce on token refresh OAuth #12208

Merged
merged 1 commit into from Nov 2, 2018
Merged

[13] Reset bruteforce on token refresh OAuth #12208

merged 1 commit into from Nov 2, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Nov 2, 2018

Backport of #12130

@rullzer
Reset bruteforce on token refresh OAuth
6971ece 
When using atoken obtained via OAuth the token expires. Resulting in
brute force attempts hitting the requesting IP.

This resets the brute force attempts for that UID on a valid refresh of
the token.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added the 3. to review Waiting for reviews label Nov 2, 2018
@rullzer rullzer added this to the Nextcloud 13.0.8 milestone Nov 2, 2018
MorrisJobke
MorrisJobke approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

Dagefoerde
Dagefoerde approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@Dagefoerde Dagefoerde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 2, 2018
@rullzer rullzer merged commit 3aaeaf1 into stable13 Nov 2, 2018
@rullzer rullzer deleted the backport/12130/stable13 branch November 2, 2018 10:38
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
Merged
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@Dagefoerde Dagefoerde Dagefoerde approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 13.0.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rullzer @MorrisJobke @Dagefoerde