Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests #1227

Merged
merged 2 commits into from
Sep 1, 2016
Merged

Improve tests #1227

merged 2 commits into from
Sep 1, 2016

Conversation

MorrisJobke
Copy link
Member

  • removes unneeded method that is windows only
  • properly loads APCu to run these tests

cc @rullzer @nickvergessen

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Sep 1, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Sep 1, 2016
@MorrisJobke
Copy link
Member Author

Before:

PHP 5.6: There were 88 skipped tests
PHP 7.0: There were 87 skipped tests

@MorrisJobke
Copy link
Member Author

After:

PHP 5.6: There were 68 skipped tests
PHP 7.0: Failing ... I will split out the PHP 7 part in a separate PR.

@rullzer
Copy link
Member

rullzer commented Sep 1, 2016

Shouldn't we do proper test splits for the different cache backends?

@MorrisJobke
Copy link
Member Author

Shouldn't we do proper test splits for the different cache backends?

That too

@MorrisJobke MorrisJobke mentioned this pull request Sep 1, 2016
Merged
@MorrisJobke
Copy link
Member Author

@LukasReschke mind to review this easy one?

@rullzer
Copy link
Member

rullzer commented Sep 1, 2016

👍

@MorrisJobke
Copy link
Member Author

@nickvergessen mind to review this one as well?

@nickvergessen
Copy link
Member

👍

@nickvergessen nickvergessen merged commit d3f8235 into master Sep 1, 2016
@nickvergessen nickvergessen deleted the improve-tests branch September 1, 2016 12:02
@MorrisJobke MorrisJobke mentioned this pull request Nov 8, 2016
Merged
@MorrisJobke
Copy link
Member Author

Stable10: #2048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MorrisJobke @rullzer @nickvergessen