New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14] A folder should get a folder mimetype #12297

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Nov 6, 2018

Backport of #12127

A folder should get a folder mimetype
If doing achunked upload the mimetype of the folder would otherwise be
guessed from the path. Which always returned application/octet-stream.

If an access control rule to block that is in place this means that all
chunked uploads fail hard in directories as the isCreatable on the
directory always fails.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer added the 3. to review label Nov 6, 2018

@rullzer rullzer added this to the Nextcloud 14.0.4 milestone Nov 6, 2018

@MorrisJobke MorrisJobke merged commit 358512f into stable14 Nov 6, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the backport/12127/stable14 branch Nov 6, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 13, 2018

Merged

14.0.4 RC 1 #12436

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

14.0.4 #12586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment