Cleanup middleware registering #12621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
added
3. to review
rullzer
requested review from
ChristophWurst,
MorrisJobke,
nickvergessen,
icewind1991 and
kesselb
rullzer
force-pushed
the
td/12224/cleanup_middleware_registering
branch
from
bfbc52c
to
30af35d
Compare
rullzer
force-pushed
the
td/12224/cleanup_middleware_registering
branch
from
30af35d
to
499668b
Compare
|
@rullzer what is the status of this one? |
status; waiting for me to have some time and finish it |
rullzer
force-pushed
the
td/12224/cleanup_middleware_registering
branch
from
499668b
to
4b695a4
Compare
Fixes #12224 Since we only use the middleware at 1 location it makes no sense to register them in each and every container. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
td/12224/cleanup_middleware_registering
branch
from
4b695a4
to
54ff913
Compare
MorrisJobke
approved these changes
Jan 3, 2019
ChristophWurst
approved these changes
Jan 7, 2019
| ) | ||
| ); | ||
| $dispatcher->registerMiddleware( | ||
| new CORSMiddleware( |
There was a problem hiding this comment.
In a follow-up PR we could also have these instances constructed by the container if possible 😉
There was a problem hiding this comment.
Yeah we could. But it is less of an issue since it is a static list. But agreed for later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12224
Since we only use the middleware at 1 location it makes no sense to
register them in each and every container.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl