Remove old button to submit the apppassword login #12710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
rullzer,
MorrisJobke,
jancborchardt,
juliushaertl and
tobiasKaminsky
MorrisJobke
approved these changes
Nov 28, 2018
juliushaertl
approved these changes
Nov 28, 2018
skjnldsv
added
2. developing
MorrisJobke
previously requested changes
Nov 28, 2018
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
remove-old-submit-button
branch
from
80b519d
to
5e4990f
Compare
tobiasKaminsky
approved these changes
Nov 29, 2018
skjnldsv
added
4. to release
|
/backport to stable15 |
|
backport to stable15 in #12723 |
|
@schiessle Could you test this with SSO? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nextcloud/designers
Fix #12404
Basically we now have this step before that have this 'Grant access' button, so we do not need to submit anything again :)