New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Don't print exception message in HTML #1343

Merged
merged 1 commit into from Sep 9, 2016

Conversation

Projects
None yet
4 participants
@LukasReschke
Member

LukasReschke commented Sep 9, 2016

The exception message is potentially influenced by user input and could thus be confusing (e.g. somebody could try to open a file like "Please send a mail to support@foo.com", and then the message would include that string.

It is thus reasonable to not show the exception message by default. Also for the browser view I added an exit() at the end, as otherwise the XML exception would be attached.

Stable10 for #1342

Don't print exception message in HTML
The exception message is potentially influenced by user input and could thus be confusing (e.g. somebody could try to open a file like "Please send a mail to support@foo.com", and then the message would include that string.

It is thus reasonable to not show the exception message by default. Also for the browser view I added an `exit()` at the end, as otherwise the XML exception would be attached.

@LukasReschke LukasReschke added this to the Nextcloud 10.0.1 milestone Sep 9, 2016

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 9, 2016

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975 and @nickvergessen to be potential reviewers

mention-bot commented Sep 9, 2016

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975 and @nickvergessen to be potential reviewers

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 9, 2016

Member

Tested and works 👍

Member

MorrisJobke commented Sep 9, 2016

Tested and works 👍

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Sep 9, 2016

Member

LGTM

Member

rullzer commented Sep 9, 2016

LGTM

@rullzer rullzer merged commit 70231dc into stable10 Sep 9, 2016

4 checks passed

Scrutinizer No new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rullzer rullzer deleted the stable10-throw-exceptions-not-printable branch Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment