Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing preview unit tests #1372

Merged
merged 1 commit into from
Sep 12, 2016
Merged

Fix failing preview unit tests #1372

merged 1 commit into from
Sep 12, 2016

Conversation

MorrisJobke
Copy link
Member

cc @rullzer @nickvergessen

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews downstream labels Sep 12, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Sep 12, 2016
@MorrisJobke
Copy link
Member Author

I reverted the removal of the PHP 5.6 switch for a test case, because we fixed it on our side properly

58dd278

@rullzer
Copy link
Member

rullzer commented Sep 12, 2016

LGTM

@MorrisJobke
Copy link
Member Author

@LukasReschke easy one ;)

@LukasReschke
Copy link
Member

LGTM :)

@LukasReschke LukasReschke merged commit eab25d5 into master Sep 12, 2016
@LukasReschke LukasReschke deleted the upstream-26039 branch September 12, 2016 22:34
@MorrisJobke
Copy link
Member Author

Should we backport this? cc @rullzer @LukasReschke

@MorrisJobke
Copy link
Member Author

Ah no - we already fixed this properly back then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MorrisJobke @rullzer @LukasReschke @DeepDiver1975