Update User_LDAP.php #13755
Closed
Update User_LDAP.php #13755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO is failing because the commit is not signed-off |
userManager->getAttributes() could be returning empty values, which will give no result when used for searching. This patch will simply drop empty values in the $attrs before using it for searching. Signed-off-by: Samuel Retika <m_samuel_l@hotmail.com>
|
Sure thing. Done. |
|
@sretika2 it should not return empty attributes, cf. https://github.com/nextcloud/server/blob/master/apps/user_ldap/lib/User/Manager.php#L200-L205 |
|
As there is no feedback since a while I will close this ticket. If this is still a problem please feel free to reopen and explain what is happening in detail. Maybe together with some debug logs with the variable values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
userManager->getAttributes() could be returning empty values, which will give no result when used for searching. This patch will simply drop empty values in the $attrs before using it for searching.