Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable15] Clean pending 2FA authentication on password reset #13915

Merged
merged 1 commit into from Jan 30, 2019
Merged

[stable15] Clean pending 2FA authentication on password reset #13915

merged 1 commit into from Jan 30, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jan 30, 2019

Backport of #13869

@rullzer
Clean pending 2FA authentication on password reset
355b0de 
When a password is reste we should make sure that all users are properly
logged in. Pending states should be cleared. For example a session where
the 2FA code is not entered yet should be cleared.

The token is now removed so the session will be killed the next time
this is checked (within 5 minutes).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added the 3. to review Waiting for reviews label Jan 30, 2019
@rullzer rullzer added this to the Nextcloud 15.0.3 milestone Jan 30, 2019
@MorrisJobke MorrisJobke mentioned this pull request Jan 30, 2019
Merged
MorrisJobke
MorrisJobke approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 30, 2019
@MorrisJobke MorrisJobke merged commit 4e131ad into stable15 Jan 30, 2019
@MorrisJobke MorrisJobke deleted the backport/13869/stable15 branch January 30, 2019 13:25
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 15.0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rullzer @MorrisJobke @ChristophWurst