Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authtoken index length #14025

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Fix authtoken index length #14025

merged 1 commit into from
Feb 25, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Feb 5, 2019

@skjnldsv you probably need to fix others as well

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added bug 3. to review Waiting for reviews labels Feb 5, 2019
@rullzer rullzer added this to the Nextcloud 16 milestone Feb 5, 2019
@@ -523,7 +523,7 @@ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $op
]);
$table->setPrimaryKey(['id']);
$table->addUniqueIndex(['token'], 'authtoken_token_index');
$table->addIndex(['last_activity'], 'authtoken_last_activity_index');
$table->addIndex(['last_activity'], 'authtoken_last_activity_idx');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this bite us in the future because it only applies to new instances? Then old ones might be forgotten. This is just something that came to my mind and I have no good example why this should be an issue, but nevertheless want to bring it up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it could. But right now the to long index does 💥 on some setups (because we check for the 27 chars for oracle 🙈 )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an option for a long running repair step that can be indicated with the "fix indexes" warning we already have?

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if this breaks, why are the tests not failing?

@rullzer
Copy link
Member Author

rullzer commented Feb 5, 2019

@nickvergessen good question. But it does for @skjnldsv

@nickvergessen
Copy link
Member

@skjnldsv can you share the error?

@skjnldsv
Copy link
Member

skjnldsv commented Feb 21, 2019

@nickvergessen
Error while trying to create admin user: Index name "authtoken"."authtoken_last_activity_index" is too long.

Somehow I also got this, but I don't thing it's related. I tried with the root db user and no error in the logs, though the index too long issue is still here!

{
  "reqId": "l4rfrltPoHplrBw6TkZ3",
  "level": 1,
  "time": "2019-02-21T11:39:07+00:00",
  "remoteAddr": "172.25.0.1",
  "user": "--",
  "app": "core",
  "method": "POST",
  "url": "/index.php",
  "message": "Autoconfig file found, setting up ownCloud…",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36",
  "version": ""
}
{
  "reqId": "l4rfrltPoHplrBw6TkZ3",
  "level": 1,
  "time": "2019-02-21T11:39:07+00:00",
  "remoteAddr": "172.25.0.1",
  "user": "--",
  "app": "mysql.setup",
  "method": "POST",
  "url": "/index.php",
  "message": {
    "Exception": "Doctrine\\DBAL\\Exception\\ConnectionException",
    "Message": "An exception occurred while executing 'SELECT user FROM mysql.user WHERE user=?' with params [\"oc_admin\"]:\n\nSQLSTATE[42000]: Syntax error or access violation: 1142 SELECT command denied to user 'nextcloud'@'172.25.0.5' for table 'user'",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
        "line": 184,
        "function": "convertException",
        "class": "Doctrine\\DBAL\\Driver\\AbstractMySQLDriver",
        "type": "->",
        "args": [
          "An exception occurred while executing 'SELECT user FROM mysql.user WHERE user=?' with params [\"oc_admin\"]:\n\nSQLSTATE[42000]: Syntax error or access violation: 1142 SELECT command denied to user 'nextcloud'@'172.25.0.5' for table 'user'",
          {
            "errorInfo": [
              "42000",
              1142,
              "SELECT command denied to user 'nextcloud'@'172.25.0.5' for table 'user'"
            ],
            "xdebug_message": "<tr><th align='left' bgcolor='#f57900' colspan=\"5\"><span style='background-color: #cc0000; color: #fce94f; font-size: x-large;'>( ! )</span> Doctrine\\DBAL\\Driver\\PDOException: SQLSTATE[42000]: Syntax error or access violation: 1142 SELECT command denied to user 'nextcloud'@'172.25.0.5' for table 'user' in /var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php on line <i>143</i></th></tr>\n<tr><th align='left' bgcolor='#e9b96e' colspan='5'>Call Stack</th></tr>\n<tr><th align='center' bgcolor='#eeeeec'>#</th><th align='left' bgcolor='#eeeeec'>Time</th><th align='left' bgcolor='#eeeeec'>Memory</th><th align='left' bgcolor='#eeeeec'>Function</th><th align='left' bgcolor='#eeeeec'>Location</th></tr>\n<tr><td bgcolor='#eeeeec' align='center'>1</td><td bgcolor='#eeeeec' align='center'>0.0000</td><td bgcolor='#eeeeec' align='right'>398400</td><td bgcolor='#eeeeec'>{main}(  )</td><td title='/var/www/html/index.php' bgcolor='#eeeeec'>.../index.php<b>:</b>0</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>2</td><td bgcolor='#eeeeec' align='center'>0.0321</td><td bgcolor='#eeeeec' align='right'>1886504</td><td bgcolor='#eeeeec'>OC::handleRequest(  )</td><td title='/var/www/html/index.php' bgcolor='#eeeeec'>.../index.php<b>:</b>42</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>3</td><td bgcolor='#eeeeec' align='center'>0.0326</td><td bgcolor='#eeeeec' align='right'>1886528</td><td bgcolor='#eeeeec'>OC\\Core\\Controller\\SetupController->run(  )</td><td title='/var/www/html/lib/base.php' bgcolor='#eeeeec'>.../base.php<b>:</b>925</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>4</td><td bgcolor='#eeeeec' align='center'>0.0392</td><td bgcolor='#eeeeec' align='right'>2050728</td><td bgcolor='#eeeeec'>OC\\Setup->install(  )</td><td title='/var/www/html/core/Controller/SetupController.php' bgcolor='#eeeeec'>.../SetupController.php<b>:</b>67</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>5</td><td bgcolor='#eeeeec' align='center'>0.0468</td><td bgcolor='#eeeeec' align='right'>2055080</td><td bgcolor='#eeeeec'>OC\\Setup\\MySQL->setupDatabase(  )</td><td title='/var/www/html/lib/private/Setup.php' bgcolor='#eeeeec'>.../Setup.php<b>:</b>348</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>6</td><td bgcolor='#eeeeec' align='center'>0.0626</td><td bgcolor='#eeeeec' align='right'>2530832</td><td bgcolor='#eeeeec'>OC\\Setup\\MySQL->createSpecificUser(  )</td><td title='/var/www/html/lib/private/Setup/MySQL.php' bgcolor='#eeeeec'>.../MySQL.php<b>:</b>50</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>7</td><td bgcolor='#eeeeec' align='center'>0.0626</td><td bgcolor='#eeeeec' align='right'>2531248</td><td bgcolor='#eeeeec'>OC\\DB\\Connection->executeQuery(  )</td><td title='/var/www/html/lib/private/Setup/MySQL.php' bgcolor='#eeeeec'>.../MySQL.php<b>:</b>136</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>8</td><td bgcolor='#eeeeec' align='center'>0.0626</td><td bgcolor='#eeeeec' align='right'>2531248</td><td bgcolor='#eeeeec'>OC\\DB\\Connection->executeQuery(  )</td><td title='/var/www/html/lib/private/DB/Connection.php' bgcolor='#eeeeec'>.../Connection.php<b>:</b>195</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>9</td><td bgcolor='#eeeeec' align='center'>0.0632</td><td bgcolor='#eeeeec' align='right'>2533072</td><td bgcolor='#eeeeec'>Doctrine\\DBAL\\Driver\\PDOStatement->execute(  )</td><td title='/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php' bgcolor='#eeeeec'>.../Connection.php<b>:</b>932</td></tr>\n",
            "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
          }
        ]
      },
      {
        "file": "/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php",
        "line": 158,
        "function": "wrapException",
        "class": "Doctrine\\DBAL\\DBALException",
        "type": "::",
        "args": [
          {
            "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
          },
          {
            "errorInfo": [
              "42000",
              1142,
              "SELECT command denied to user 'nextcloud'@'172.25.0.5' for table 'user'"
            ],
            "xdebug_message": "<tr><th align='left' bgcolor='#f57900' colspan=\"5\"><span style='background-color: #cc0000; color: #fce94f; font-size: x-large;'>( ! )</span> Doctrine\\DBAL\\Driver\\PDOException: SQLSTATE[42000]: Syntax error or access violation: 1142 SELECT command denied to user 'nextcloud'@'172.25.0.5' for table 'user' in /var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php on line <i>143</i></th></tr>\n<tr><th align='left' bgcolor='#e9b96e' colspan='5'>Call Stack</th></tr>\n<tr><th align='center' bgcolor='#eeeeec'>#</th><th align='left' bgcolor='#eeeeec'>Time</th><th align='left' bgcolor='#eeeeec'>Memory</th><th align='left' bgcolor='#eeeeec'>Function</th><th align='left' bgcolor='#eeeeec'>Location</th></tr>\n<tr><td bgcolor='#eeeeec' align='center'>1</td><td bgcolor='#eeeeec' align='center'>0.0000</td><td bgcolor='#eeeeec' align='right'>398400</td><td bgcolor='#eeeeec'>{main}(  )</td><td title='/var/www/html/index.php' bgcolor='#eeeeec'>.../index.php<b>:</b>0</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>2</td><td bgcolor='#eeeeec' align='center'>0.0321</td><td bgcolor='#eeeeec' align='right'>1886504</td><td bgcolor='#eeeeec'>OC::handleRequest(  )</td><td title='/var/www/html/index.php' bgcolor='#eeeeec'>.../index.php<b>:</b>42</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>3</td><td bgcolor='#eeeeec' align='center'>0.0326</td><td bgcolor='#eeeeec' align='right'>1886528</td><td bgcolor='#eeeeec'>OC\\Core\\Controller\\SetupController->run(  )</td><td title='/var/www/html/lib/base.php' bgcolor='#eeeeec'>.../base.php<b>:</b>925</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>4</td><td bgcolor='#eeeeec' align='center'>0.0392</td><td bgcolor='#eeeeec' align='right'>2050728</td><td bgcolor='#eeeeec'>OC\\Setup->install(  )</td><td title='/var/www/html/core/Controller/SetupController.php' bgcolor='#eeeeec'>.../SetupController.php<b>:</b>67</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>5</td><td bgcolor='#eeeeec' align='center'>0.0468</td><td bgcolor='#eeeeec' align='right'>2055080</td><td bgcolor='#eeeeec'>OC\\Setup\\MySQL->setupDatabase(  )</td><td title='/var/www/html/lib/private/Setup.php' bgcolor='#eeeeec'>.../Setup.php<b>:</b>348</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>6</td><td bgcolor='#eeeeec' align='center'>0.0626</td><td bgcolor='#eeeeec' align='right'>2530832</td><td bgcolor='#eeeeec'>OC\\Setup\\MySQL->createSpecificUser(  )</td><td title='/var/www/html/lib/private/Setup/MySQL.php' bgcolor='#eeeeec'>.../MySQL.php<b>:</b>50</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>7</td><td bgcolor='#eeeeec' align='center'>0.0626</td><td bgcolor='#eeeeec' align='right'>2531248</td><td bgcolor='#eeeeec'>OC\\DB\\Connection->executeQuery(  )</td><td title='/var/www/html/lib/private/Setup/MySQL.php' bgcolor='#eeeeec'>.../MySQL.php<b>:</b>136</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>8</td><td bgcolor='#eeeeec' align='center'>0.0626</td><td bgcolor='#eeeeec' align='right'>2531248</td><td bgcolor='#eeeeec'>OC\\DB\\Connection->executeQuery(  )</td><td title='/var/www/html/lib/private/DB/Connection.php' bgcolor='#eeeeec'>.../Connection.php<b>:</b>195</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>9</td><td bgcolor='#eeeeec' align='center'>0.0632</td><td bgcolor='#eeeeec' align='right'>2533072</td><td bgcolor='#eeeeec'>Doctrine\\DBAL\\Driver\\PDOStatement->execute(  )</td><td title='/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php' bgcolor='#eeeeec'>.../Connection.php<b>:</b>932</td></tr>\n",
            "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
          },
          "An exception occurred while executing 'SELECT user FROM mysql.user WHERE user=?' with params [\"oc_admin\"]:\n\nSQLSTATE[42000]: Syntax error or access violation: 1142 SELECT command denied to user 'nextcloud'@'172.25.0.5' for table 'user'"
        ]
      },
      {
        "file": "/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
        "line": 938,
        "function": "driverExceptionDuringQuery",
        "class": "Doctrine\\DBAL\\DBALException",
        "type": "::",
        "args": [
          {
            "__class__": "Doctrine\\DBAL\\Driver\\PDOMySql\\Driver"
          },
          {
            "errorInfo": [
              "42000",
              1142,
              "SELECT command denied to user 'nextcloud'@'172.25.0.5' for table 'user'"
            ],
            "xdebug_message": "<tr><th align='left' bgcolor='#f57900' colspan=\"5\"><span style='background-color: #cc0000; color: #fce94f; font-size: x-large;'>( ! )</span> Doctrine\\DBAL\\Driver\\PDOException: SQLSTATE[42000]: Syntax error or access violation: 1142 SELECT command denied to user 'nextcloud'@'172.25.0.5' for table 'user' in /var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php on line <i>143</i></th></tr>\n<tr><th align='left' bgcolor='#e9b96e' colspan='5'>Call Stack</th></tr>\n<tr><th align='center' bgcolor='#eeeeec'>#</th><th align='left' bgcolor='#eeeeec'>Time</th><th align='left' bgcolor='#eeeeec'>Memory</th><th align='left' bgcolor='#eeeeec'>Function</th><th align='left' bgcolor='#eeeeec'>Location</th></tr>\n<tr><td bgcolor='#eeeeec' align='center'>1</td><td bgcolor='#eeeeec' align='center'>0.0000</td><td bgcolor='#eeeeec' align='right'>398400</td><td bgcolor='#eeeeec'>{main}(  )</td><td title='/var/www/html/index.php' bgcolor='#eeeeec'>.../index.php<b>:</b>0</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>2</td><td bgcolor='#eeeeec' align='center'>0.0321</td><td bgcolor='#eeeeec' align='right'>1886504</td><td bgcolor='#eeeeec'>OC::handleRequest(  )</td><td title='/var/www/html/index.php' bgcolor='#eeeeec'>.../index.php<b>:</b>42</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>3</td><td bgcolor='#eeeeec' align='center'>0.0326</td><td bgcolor='#eeeeec' align='right'>1886528</td><td bgcolor='#eeeeec'>OC\\Core\\Controller\\SetupController->run(  )</td><td title='/var/www/html/lib/base.php' bgcolor='#eeeeec'>.../base.php<b>:</b>925</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>4</td><td bgcolor='#eeeeec' align='center'>0.0392</td><td bgcolor='#eeeeec' align='right'>2050728</td><td bgcolor='#eeeeec'>OC\\Setup->install(  )</td><td title='/var/www/html/core/Controller/SetupController.php' bgcolor='#eeeeec'>.../SetupController.php<b>:</b>67</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>5</td><td bgcolor='#eeeeec' align='center'>0.0468</td><td bgcolor='#eeeeec' align='right'>2055080</td><td bgcolor='#eeeeec'>OC\\Setup\\MySQL->setupDatabase(  )</td><td title='/var/www/html/lib/private/Setup.php' bgcolor='#eeeeec'>.../Setup.php<b>:</b>348</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>6</td><td bgcolor='#eeeeec' align='center'>0.0626</td><td bgcolor='#eeeeec' align='right'>2530832</td><td bgcolor='#eeeeec'>OC\\Setup\\MySQL->createSpecificUser(  )</td><td title='/var/www/html/lib/private/Setup/MySQL.php' bgcolor='#eeeeec'>.../MySQL.php<b>:</b>50</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>7</td><td bgcolor='#eeeeec' align='center'>0.0626</td><td bgcolor='#eeeeec' align='right'>2531248</td><td bgcolor='#eeeeec'>OC\\DB\\Connection->executeQuery(  )</td><td title='/var/www/html/lib/private/Setup/MySQL.php' bgcolor='#eeeeec'>.../MySQL.php<b>:</b>136</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>8</td><td bgcolor='#eeeeec' align='center'>0.0626</td><td bgcolor='#eeeeec' align='right'>2531248</td><td bgcolor='#eeeeec'>OC\\DB\\Connection->executeQuery(  )</td><td title='/var/www/html/lib/private/DB/Connection.php' bgcolor='#eeeeec'>.../Connection.php<b>:</b>195</td></tr>\n<tr><td bgcolor='#eeeeec' align='center'>9</td><td bgcolor='#eeeeec' align='center'>0.0632</td><td bgcolor='#eeeeec' align='right'>2533072</td><td bgcolor='#eeeeec'>Doctrine\\DBAL\\Driver\\PDOStatement->execute(  )</td><td title='/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php' bgcolor='#eeeeec'>.../Connection.php<b>:</b>932</td></tr>\n",
            "__class__": "Doctrine\\DBAL\\Driver\\PDOException"
          },
          "SELECT user FROM mysql.user WHERE user=?",
          {
            "1": "oc_admin"
          }
        ]
      },
      {
        "file": "/var/www/html/lib/private/DB/Connection.php",
        "line": 195,
        "function": "executeQuery",
        "class": "Doctrine\\DBAL\\Connection",
        "type": "->",
        "args": [
          "SELECT user FROM mysql.user WHERE user=?",
          [
            "oc_admin"
          ],
          [],
          null
        ]
      },
      {
        "file": "/var/www/html/lib/private/Setup/MySQL.php",
        "line": 136,
        "function": "executeQuery",
        "class": "OC\\DB\\Connection",
        "type": "->",
        "args": [
          "SELECT user FROM mysql.user WHERE user=?",
          [
            "oc_admin"
          ]
        ]
      },
      {
        "file": "/var/www/html/lib/private/Setup/MySQL.php",
        "line": 50,
        "function": "createSpecificUser",
        "class": "OC\\Setup\\MySQL",
        "type": "->",
        "args": [
          "admin",
          {
            "__class__": "OC\\DB\\Connection"
          }
        ]
      },
      {
        "file": "/var/www/html/lib/private/Setup.php",
        "line": 348,
        "function": "setupDatabase",
        "class": "OC\\Setup\\MySQL",
        "type": "->",
        "args": [
          "admin"
        ]
      },
      {
        "file": "/var/www/html/core/Controller/SetupController.php",
        "line": 67,
        "function": "install",
        "class": "OC\\Setup",
        "type": "->",
        "args": [
          {
            "install": "true",
            "adminlogin": "admin",
            "adminpass": "admin",
            "dbtype": "mysql",
            "dbname": "nextcloud",
            "dbuser": "nextcloud",
            "dbpass": "password",
            "dbhost": "db",
            "dbtableprefix": "",
            "directory": "/var/www/html/data",
            "dbIsSet": true,
            "directoryIsSet": true
          }
        ]
      },
      {
        "file": "/var/www/html/lib/base.php",
        "line": 925,
        "function": "run",
        "class": "OC\\Core\\Controller\\SetupController",
        "type": "->",
        "args": [
          {
            "install": "true",
            "adminlogin": "admin",
            "adminpass": "admin",
            "dbtype": "mysql",
            "dbname": "nextcloud",
            "dbuser": "nextcloud",
            "dbpass": "password",
            "dbhost": "db",
            "dbtableprefix": "",
            "directory": "/var/www/html/data",
            "dbIsSet": true,
            "directoryIsSet": true
          }
        ]
      },
      {
        "file": "/var/www/html/index.php",
        "line": 42,
        "function": "handleRequest",
        "class": "OC",
        "type": "::",
        "args": []
      }
    ],
    "File": "/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php",
    "Line": 112,
    "Previous": {
      "Exception": "Doctrine\\DBAL\\Driver\\PDOException",
      "Message": "SQLSTATE[42000]: Syntax error or access violation: 1142 SELECT command denied to user 'nextcloud'@'172.25.0.5' for table 'user'",
      "Code": "42000",
      "Trace": [
        {
          "file": "/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
          "line": 932,
          "function": "execute",
          "class": "Doctrine\\DBAL\\Driver\\PDOStatement",
          "type": "->",
          "args": [
            [
              "oc_admin"
            ]
          ]
        },
        {
          "file": "/var/www/html/lib/private/DB/Connection.php",
          "line": 195,
          "function": "executeQuery",
          "class": "Doctrine\\DBAL\\Connection",
          "type": "->",
          "args": [
            "SELECT user FROM mysql.user WHERE user=?",
            [
              "oc_admin"
            ],
            [],
            null
          ]
        },
        {
          "file": "/var/www/html/lib/private/Setup/MySQL.php",
          "line": 136,
          "function": "executeQuery",
          "class": "OC\\DB\\Connection",
          "type": "->",
          "args": [
            "SELECT user FROM mysql.user WHERE user=?",
            [
              "oc_admin"
            ]
          ]
        },
        {
          "file": "/var/www/html/lib/private/Setup/MySQL.php",
          "line": 50,
          "function": "createSpecificUser",
          "class": "OC\\Setup\\MySQL",
          "type": "->",
          "args": [
            "admin",
            {
              "__class__": "OC\\DB\\Connection"
            }
          ]
        },
        {
          "file": "/var/www/html/lib/private/Setup.php",
          "line": 348,
          "function": "setupDatabase",
          "class": "OC\\Setup\\MySQL",
          "type": "->",
          "args": [
            "admin"
          ]
        },
        {
          "file": "/var/www/html/core/Controller/SetupController.php",
          "line": 67,
          "function": "install",
          "class": "OC\\Setup",
          "type": "->",
          "args": [
            {
              "install": "true",
              "adminlogin": "admin",
              "adminpass": "admin",
              "dbtype": "mysql",
              "dbname": "nextcloud",
              "dbuser": "nextcloud",
              "dbpass": "password",
              "dbhost": "db",
              "dbtableprefix": "",
              "directory": "/var/www/html/data",
              "dbIsSet": true,
              "directoryIsSet": true
            }
          ]
        },
        {
          "file": "/var/www/html/lib/base.php",
          "line": 925,
          "function": "run",
          "class": "OC\\Core\\Controller\\SetupController",
          "type": "->",
          "args": [
            {
              "install": "true",
              "adminlogin": "admin",
              "adminpass": "admin",
              "dbtype": "mysql",
              "dbname": "nextcloud",
              "dbuser": "nextcloud",
              "dbpass": "password",
              "dbhost": "db",
              "dbtableprefix": "",
              "directory": "/var/www/html/data",
              "dbIsSet": true,
              "directoryIsSet": true
            }
          ]
        },
        {
          "file": "/var/www/html/index.php",
          "line": 42,
          "function": "handleRequest",
          "class": "OC",
          "type": "::",
          "args": []
        }
      ],
      "File": "/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
      "Line": 143,
      "Previous": {
        "Exception": "PDOException",
        "Message": "SQLSTATE[42000]: Syntax error or access violation: 1142 SELECT command denied to user 'nextcloud'@'172.25.0.5' for table 'user'",
        "Code": "42000",
        "Trace": [
          {
            "file": "/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
            "line": 141,
            "function": "execute",
            "class": "PDOStatement",
            "type": "->",
            "args": [
              [
                "oc_admin"
              ]
            ]
          },
          {
            "file": "/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php",
            "line": 932,
            "function": "execute",
            "class": "Doctrine\\DBAL\\Driver\\PDOStatement",
            "type": "->",
            "args": [
              [
                "oc_admin"
              ]
            ]
          },
          {
            "file": "/var/www/html/lib/private/DB/Connection.php",
            "line": 195,
            "function": "executeQuery",
            "class": "Doctrine\\DBAL\\Connection",
            "type": "->",
            "args": [
              "SELECT user FROM mysql.user WHERE user=?",
              [
                "oc_admin"
              ],
              [],
              null
            ]
          },
          {
            "file": "/var/www/html/lib/private/Setup/MySQL.php",
            "line": 136,
            "function": "executeQuery",
            "class": "OC\\DB\\Connection",
            "type": "->",
            "args": [
              "SELECT user FROM mysql.user WHERE user=?",
              [
                "oc_admin"
              ]
            ]
          },
          {
            "file": "/var/www/html/lib/private/Setup/MySQL.php",
            "line": 50,
            "function": "createSpecificUser",
            "class": "OC\\Setup\\MySQL",
            "type": "->",
            "args": [
              "admin",
              {
                "__class__": "OC\\DB\\Connection"
              }
            ]
          },
          {
            "file": "/var/www/html/lib/private/Setup.php",
            "line": 348,
            "function": "setupDatabase",
            "class": "OC\\Setup\\MySQL",
            "type": "->",
            "args": [
              "admin"
            ]
          },
          {
            "file": "/var/www/html/core/Controller/SetupController.php",
            "line": 67,
            "function": "install",
            "class": "OC\\Setup",
            "type": "->",
            "args": [
              {
                "install": "true",
                "adminlogin": "admin",
                "adminpass": "admin",
                "dbtype": "mysql",
                "dbname": "nextcloud",
                "dbuser": "nextcloud",
                "dbpass": "password",
                "dbhost": "db",
                "dbtableprefix": "",
                "directory": "/var/www/html/data",
                "dbIsSet": true,
                "directoryIsSet": true
              }
            ]
          },
          {
            "file": "/var/www/html/lib/base.php",
            "line": 925,
            "function": "run",
            "class": "OC\\Core\\Controller\\SetupController",
            "type": "->",
            "args": [
              {
                "install": "true",
                "adminlogin": "admin",
                "adminpass": "admin",
                "dbtype": "mysql",
                "dbname": "nextcloud",
                "dbuser": "nextcloud",
                "dbpass": "password",
                "dbhost": "db",
                "dbtableprefix": "",
                "directory": "/var/www/html/data",
                "dbIsSet": true,
                "directoryIsSet": true
              }
            ]
          },
          {
            "file": "/var/www/html/index.php",
            "line": 42,
            "function": "handleRequest",
            "class": "OC",
            "type": "::",
            "args": []
          }
        ],
        "File": "/var/www/html/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php",
        "Line": 141
      }
    },
    "CustomMessage": "Can not create a new MySQL user, will continue with the provided user."
  },
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36",
  "version": "16.0.0.0"
}

@MorrisJobke
Copy link
Member

Let's merge it then. Another question: why do we name indexes at all? Because if the parameter is not provided a unique name is chosen. (I did this in #14228)

@MorrisJobke MorrisJobke merged commit 01d5cc1 into master Feb 25, 2019
@MorrisJobke MorrisJobke deleted the fix/authtoken_idx_length branch February 25, 2019 20:23
@nickvergessen
Copy link
Member

why do we name indexes at all?

The problem was that in unit tests we can't check the schema whether an index exists, because the name depends on the platform::getMaxIdentifierLength() Also it's quite a Problem if we want to remove an index in the future. And since adding a nice short one is not a problem at all, we should just do that.

@MorrisJobke
Copy link
Member

The problem was that in unit tests we can't check the schema whether an index exists, because the name depends on the platform::getMaxIdentifierLength() Also it's quite a Problem if we want to remove an index in the future. And since adding a nice short one is not a problem at all, we should just do that.

Okay - but I also have seen others that don't have one. Anyways - I will add it to the ones I added in #14228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants