Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move personal auth token settings to Vue #14392

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Move personal auth token settings to Vue #14392

merged 1 commit into from
Mar 1, 2019

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Feb 26, 2019 •
edited
Loading

Required for #429

Todo

Optional

  • Switch to initial state API
  • Move (s)css to the bundle as well

Bugs

@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Feb 26, 2019
@ChristophWurst ChristophWurst self-assigned this Feb 26, 2019
@ChristophWurst ChristophWurst added this to IN PROGRESS (max 3 PRs) in Christoph's Tasks via automation Feb 26, 2019
@ChristophWurst

This comment has been minimized.

Sign in to view
@rullzer

This comment has been minimized.

Sign in to view
@ChristophWurst

This comment has been minimized.

Sign in to view
@ChristophWurst ChristophWurst mentioned this pull request Feb 27, 2019
Merged
@ChristophWurst
Copy link
Member Author

This also reduces the number of requests on the personal security settings page by three.

@ChristophWurst ChristophWurst marked this pull request as ready for review February 28, 2019 09:39
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 28, 2019
@ChristophWurst ChristophWurst moved this from IN PROGRESS (max 3 PRs) to TO REVIEW (max 4 PRs) in Christoph's Tasks Feb 28, 2019
@ChristophWurst ChristophWurst force-pushed the refactor/auth-token-Vue branch 3 times, most recently from f1b9af3 to 7cf3718 Compare February 28, 2019 13:43
rullzer
rullzer requested changes Feb 28, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If create a new apptoken. And press done. The list of apptokens is not updated.

@ChristophWurst
Move personal auth token settings to Vue
4b72475 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Always crate OC.Settings, even if not used

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Copy link
Member Author

If create a new apptoken. And press done. The list of apptokens is not updated.

Yep, https://github.com/nextcloud/server/pull/14392/files#diff-f57c51aacf630692a4a5d90e51cf3f11R86 was missing.

@ghost
Copy link

ghost commented Feb 28, 2019

🎉

Christoph's Tasks automation moved this from TO REVIEW (max 4 PRs) to TO INTEGRATE Mar 1, 2019
@rullzer rullzer merged commit e1653c9 into master Mar 1, 2019
Christoph's Tasks automation moved this from TO INTEGRATE to DONE Mar 1, 2019
@rullzer rullzer deleted the refactor/auth-token-Vue branch March 1, 2019 07:21
@ChristophWurst ChristophWurst mentioned this pull request Mar 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews enhancement
Projects
No open projects
Christoph's Tasks
DONE
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristophWurst @rullzer @juliushaertl