Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section for groups in share overview #14413

Closed
wants to merge 5 commits into from
Closed

Add a section for groups in share overview #14413

wants to merge 5 commits into from

Conversation

mamatt
Copy link

@mamatt mamatt commented Feb 27, 2019

Here is the idea,
we want to be able to see from which group files/folders has been shared !

The idea is to show group shareds in a same place.
This is to facilitate the usage of group sharing in a working context where there can be a big amount of sharing

capture d ecran de 2019-02-27 15-51-25

@ChristophWurst
Copy link
Member

cc @nextcloud/sharing for review

@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Mar 1, 2019
This was referenced Mar 4, 2019
@jancborchardt
Copy link
Member

Hmm, this is part of "Shared with others", is it not? Why the necessity to have a separate section? :)

@mamatt we try to do stuff as simple as possible, and from experience, adding another section does not facilitate use of something as it makes everything more obscure. (E.g. commenting is not widely used because it’s a separate tab in the sidebar, which is why we want to combine the chronological activity: #658 )

@jancborchardt jancborchardt removed this from the Nextcloud 16 milestone Mar 13, 2019
@mamatt
Copy link
Author

mamatt commented Mar 14, 2019

Hum in fact, this more a part of "shared whith you" and as I write it I see the confusing part :)

One main use case is, as an example:
"Some file were shard with the financial service group , one week after some other files, and so on.
Some month later, some users from this group want to know what files were shared with financial services groups ? For now there is no place to find this information !"

I understand you're feeling about keeping the interface simple, so maybe it should be integrated with "shared with you".

Maybe in the "shared with you" filelist, it should have sections.

I had try to keep the PR simple, maybe this not a simple problem at all :)

@jancborchardt
Copy link
Member

jancborchardt commented Mar 14, 2019

"Some file were shard with the financial service group , one week after some other files, and so on.
Some month later, some users from this group want to know what files were shared with financial services groups ? For now there is no place to find this information !"

Thanks a lot for describing the requirements, that’s very important! :)

Would this section then take care of that even? Because if you are part of multiple groups, you don’t really know which group it is?

Alternatively we could show the group icon (or overlapped avatars) on the right where normally the original sharer is shown. That way you directly know it’s a group share, and we don’t need a specific section.

Because when your question is "What has been shared with the 'Financial Services' group" (for example) then this question should not need navigating to a specific section to be answered. As then we have to tell everyone they find that information there. :)

What do you think?

@MorrisJobke MorrisJobke added this to the Nextcloud 17 milestone Mar 20, 2019
@mamatt
Copy link
Author

mamatt commented Mar 20, 2019

I think that adding the group name /avatar to the filelist directly in "the shared with you" overview is the right way, as long as it is possible to sort by group !

Should we close this PR as i think it is now not relevant !

@mamatt
Copy link
Author

mamatt commented Mar 26, 2019

I'm closing the PR as it is not relevant anymore !

@mamatt mamatt closed this Mar 26, 2019
@MorrisJobke MorrisJobke removed this from the Nextcloud 17 milestone Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants