Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully check compliant apps #14560

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Conversation

MorrisJobke
Copy link
Member

Found while digging through #14373

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 6, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 6, 2019
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 6, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 6, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16811: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

  • tests/acceptance/features/app-comments.feature:195
Show full log
  Scenario: unread comment icon shown for comment written by the sharee in a child folder of a shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-comments.feature:195
    Given I act as John                                                                                      # ActorContext::iActAs()
    And I am logged in as the admin                                                                          # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                                                        # ActorContext::iActAs()
    And I am logged in                                                                                       # LoginPageContext::iAmLoggedIn()
    And I act as John                                                                                        # ActorContext::iActAs()
    And I create a new folder named "Folder"                                                                 # FileListContext::iCreateANewFolderNamed()
    And I share "Folder" with "user0"                                                                        # FilesAppSharingContext::iShareWith()
      Share action for file Folder in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that the file is shared with "user0"                                                           # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                                                        # ActorContext::iActAs()
    And I open the Files app                                                                                 # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Folder"                                                                 # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Child folder"                                                           # FileListContext::iCreateANewFolderNamed()
    And I open the "Comments" tab in the details view                                                        # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I create a new comment with "Hello world" as message                                                 # CommentsAppContext::iCreateANewCommentWithAsMessage()
    And I see a comment with "Hello world" as message                                                        # CommentsAppContext::iSeeACommentWithAsMessage()
    When I act as John                                                                                       # ActorContext::iActAs()
    And I enter in the folder named "Folder"                                                                 # FileListContext::iEnterInTheFolderNamed()
    Then I see that "Child folder" has unread comments                                                       # FileListContext::iSeeThatHasUnreadComments()
    And I open the unread comments for "Child folder"                                                        # FileListContext::iOpenTheUnreadCommentsFor()
    And I see that the details view is open                                                                  # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I see a comment with "Hello world" as message                                                        # CommentsAppContext::iSeeACommentWithAsMessage()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link

  • tests/acceptance/features/app-files-sharing-link.feature:60
Show full log
  Scenario: create folder in a public editable shared folder        # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:60
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Editable shared folder"        # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                    # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                       # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"               # FilesAppSharingContext::iShareTheLinkFor()
      Share action for file Editable shared folder in file list could not be found after 100 seconds (NoSuchElementException)
    And I set the shared link as editable                           # FilesAppSharingContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                     # FileListContext::iCreateANewFolderNamed()
    Then I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

@MorrisJobke MorrisJobke merged commit d77bab9 into master Mar 6, 2019
@MorrisJobke MorrisJobke deleted the tests/noid/fully-check-compliant-apps branch March 6, 2019 13:00
@MorrisJobke MorrisJobke mentioned this pull request Mar 6, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants