Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the jquery version to 2.1.4 #14563

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Pin the jquery version to 2.1.4 #14563

merged 1 commit into from
Mar 6, 2019

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 6, 2019

v2.2.x behaves different in terms of when the page is ready. See #13496 (comment) for more detail. Apparently 7207a77 updated jquery accidentally.

Fixes #14556

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Mar 6, 2019
@ChristophWurst ChristophWurst self-assigned this Mar 6, 2019
@ChristophWurst ChristophWurst added this to IN PROGRESS (max 3 PRs) in Christoph's Tasks via automation Mar 6, 2019
@ChristophWurst
Copy link
Member Author

How to test: run npm ls jquery on master and this branch ;)

Christoph's Tasks automation moved this from IN PROGRESS (max 3 PRs) to TO INTEGRATE Mar 6, 2019
@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 6, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 6, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16815: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:75
Show full log
  Scenario: View app details for app store apps   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:75
    Given I act as Jane                           # ActorContext::iActAs()
    And I am logged in as the admin               # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                # SettingsMenuContext::iOpenTheAppsManagement()
    And I open the "Tools" section                # AppNavigationContext::iOpenTheSection()
      Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)
    When I click on the "Antivirus for files" app # AppsManagementContext::iClickOnTheApp()
    Then I see that the app details are shown     # AppsManagementContext::iSeeThatTheAppDetailsAreShown()

@MorrisJobke MorrisJobke merged commit 540ec4f into master Mar 6, 2019
Christoph's Tasks automation moved this from TO INTEGRATE to DONE Mar 6, 2019
@MorrisJobke MorrisJobke deleted the fix/jquery-version branch March 6, 2019 14:32
@MorrisJobke MorrisJobke mentioned this pull request Mar 6, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug regression
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants