-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add border around previews #14637
Add border around previews #14637
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Quick review please @nextcloud/designers :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot better 👍
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 17017: failureTESTS=acceptance, TESTS-ACCEPTANCE=apps
Show full log
TESTS=syntax-php7.3
|
"fixed" in #14681 |
Very nice, and yeah, I suggested it as I am always taking screenshots, those have a lot of white on sides and bottom and thus look odd without a border ;-) |
@skjnldsv as discussed, so it looks a bit nicer. I think it was suggested by @jospoortvliet