Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the icon-class with an absolute link to an image #14664

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 13, 2019

Otherwise the icon can not be displayed in mobile apps

ToDo:

@juliushaertl juliushaertl force-pushed the bugfix/noid/absolute-paths-of-images-for-linked-collaboration-resources branch from 266f5b6 to 5898621 Compare March 14, 2019 17:30
@faily-bot
Copy link

faily-bot bot commented Mar 18, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17121: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link

  • tests/acceptance/features/app-files-sharing-link.feature:116
Show full log
  Scenario: access a shared link protected by password with a valid password                   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:116
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                  # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                           # FilesAppSharingContext::iWriteDownTheSharedLink()
      Element is no longer attached to the DOM
      For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
      Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      System info: host: '6596426a0668', ip: '172.17.0.12', os.name: 'Linux', os.arch: 'amd64', os.version: '4.4.0-141-generic', java.version: '1.8.0_91'
      Driver info: driver.version: unknown (WebDriver\Exception\StaleElementReference)
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I visit the shared link I wrote down                                                   # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the Authenticate page for the shared link I wrote down  # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
    And I authenticate with password "abcdef"                                                  # PublicShareContext::iAuthenticateWithPassword()
    Then I see that the current page is the shared link I wrote down                           # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I see that the shared file preview shows the text "Welcome to your Nextcloud account!" # PublicShareContext::iSeeThatTheSharedFilePreviewShowsTheText()

nickvergessen and others added 8 commits March 19, 2019 13:06
Otherwise the icon can not be displayed in mobile apps

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@juliushaertl juliushaertl force-pushed the bugfix/noid/absolute-paths-of-images-for-linked-collaboration-resources branch from cd1aa59 to 21425eb Compare March 19, 2019 13:53
@juliushaertl juliushaertl added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 19, 2019
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane

@rullzer rullzer merged commit 2fcb6dd into master Mar 19, 2019
@rullzer rullzer deleted the bugfix/noid/absolute-paths-of-images-for-linked-collaboration-resources branch March 19, 2019 18:23
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants