Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always allow moving mountpoints inside the same mountpoint #14691

Merged
merged 1 commit into from Mar 20, 2019
Merged

always allow moving mountpoints inside the same mountpoint #14691

merged 1 commit into from Mar 20, 2019

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Mar 14, 2019 •
edited by MorrisJobke

even if that mountpoint isn't normally a valid target for moving mounts into

Fixes #13451

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 14, 2019
@icewind1991 icewind1991 added this to the Nextcloud 16 milestone Mar 14, 2019
@icewind1991
Copy link
Member Author

/backport to stable15

@icewind1991
Copy link
Member Author

/backport to stable14

@icewind1991
Copy link
Member Author

Fixes #13451

MorrisJobke
MorrisJobke approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

rullzer
rullzer approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🐘

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@MorrisJobke MorrisJobke mentioned this pull request Mar 14, 2019
Merged
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 14, 2019
@icewind1991
always allow moving mountpoints inside the same mountpoint
cc29f5d 
even if that mountpoint isn't normally a valid target for moving mounts into

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the rename-mountpoint-within-mountpoint branch from 99c81e9 to cc29f5d Compare March 19, 2019 14:56
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
@nextcloud nextcloud deleted a comment from faily-bot bot Mar 20, 2019
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Mar 20, 2019
MorrisJobke
MorrisJobke approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested and still works 👍

@rullzer rullzer merged commit 6458dd8 into master Mar 20, 2019
@rullzer rullzer deleted the rename-mountpoint-within-mountpoint branch March 20, 2019 09:58
@MorrisJobke
Copy link
Member

/backport to stable15

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 20, 2019
Merged
@MorrisJobke
Copy link
Member

/backport to stable14

@backportbot-nextcloud
Copy link

backport to stable15 in #14759

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 20, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable14 in #14760

@MorrisJobke MorrisJobke mentioned this pull request Mar 25, 2019
Closed
@nickvergessen nickvergessen mentioned this pull request Mar 25, 2019
Merged
@MorrisJobke MorrisJobke mentioned this pull request Mar 25, 2019
Closed
@skjnldsv skjnldsv mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icewind1991 @MorrisJobke @rullzer