Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP: set nonce for iframes #14724

Merged
merged 1 commit into from
Mar 18, 2019
Merged

CSP: set nonce for iframes #14724

merged 1 commit into from
Mar 18, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Mar 16, 2019

This for now uses the jsNonce. That way we can easily backport it.
For 17 I will fix it properly.

This for now uses the jsNonce. That way we can easily backport it.
For 17 I will fix it properly.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added enhancement 3. to review Waiting for reviews labels Mar 16, 2019
@rullzer rullzer added this to the Nextcloud 16 milestone Mar 16, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 16, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17097: failure

TESTS=ui-regression

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke MorrisJobke merged commit 4583595 into master Mar 18, 2019
@MorrisJobke MorrisJobke deleted the enh/nonce_for_iframes branch March 18, 2019 15:17
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants