Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve startup speed of acceptance tests #14737

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Improve startup speed of acceptance tests #14737

merged 1 commit into from
Mar 18, 2019

Conversation

nickvergessen
Copy link
Member

Actual change is to add --exclude="node_modules"
Then I added line breaks for readability and better adding new entries locally.

@nickvergessen
Improve startup speed of acceptance tests
b357913 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Mar 18, 2019
@nickvergessen nickvergessen added this to the Nextcloud 16 milestone Mar 18, 2019
MorrisJobke
MorrisJobke approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense 👍

rullzer
rullzer approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is happy I'm fine

@rullzer rullzer merged commit 8c04972 into master Mar 18, 2019
@rullzer rullzer deleted the improve-starting-speed-of-acceptance-tests branch March 18, 2019 15:21
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
@danxuliu danxuliu mentioned this pull request Apr 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickvergessen @rullzer @MorrisJobke