Autocomplete for occ app commands

[nickvergessen]

• 3rdparty: Add stecman/symfony-console-completion 3rdparty#16
• Run one of step 3 from https://github.com/stecman/symfony-console-completion#zero-config-use, aka:

# BASH ~4.x, ZSH
source <([program] _completion --generate-hook)

# BASH ~3.x, ZSH
[program] _completion --generate-hook | source /dev/stdin

# BASH (any version)
eval $([program] _completion --generate-hook)

And enjoy full autocompelete for everything on the app:* commands (app names, group ids, etc.)

Todo

• app:*
• config:*
• db:*
• l10n:*
• log:*
• security:*
• twofactorauth:*

For another PR to keep it simple

• encryption:*
• group:*
• integrity:*
• maintenance:*
• user:*

@MorrisJobke @LukasReschke @ChristophWurst

[mention-bot]

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @MorrisJobke and @Xenopathic to be potential reviewers

[LukasReschke]

Merged nextcloud/3rdparty#16 and updated third-party reference to nextcloud/3rdparty@cc365d1

[LukasReschke]

@nickvergessen So what command do I have to execute exactly? All those three you posted don't work locally here. I guess I miss something obvious ;)

[nickvergessen]

For me I execute eval $(/var/www/nextcloud/occ _completion --generate-hook)

Afterwards /var/www/nextcloud/occ main<tab> autocompletes maintenance:

[LukasReschke]

Works nicely, I commited regenerated autoloading files 👍

[MorrisJobke]

I get this in my zsh (while trying the autocomplete):

$ occ <tab>

  [RuntimeException]                                                               
  Failed to configure from environment; Environment var CMDLINE_CONTENTS not set.  


_completion [-g|--generate-hook] [-p|--program PROGRAM] [-m|--multiple] [--shell-type [SHELL-TYPE]]


_occ_48ee92c85c317686_complete:local: not valid in this context: -x


  [RuntimeException]                                                               
  Failed to configure from environment; Environment var CMDLINE_CONTENTS not set.  


_completion [-g|--generate-hook] [-p|--program PROGRAM] [-m|--multiple] [--shell-type [SHELL-TYPE]]

_occ_48ee92c85c317686_complete:local: not valid in this context: -x


  [RuntimeException]                                                               
  Failed to configure from environment; Environment var CMDLINE_CONTENTS not set.  


_completion [-g|--generate-hook] [-p|--program PROGRAM] [-m|--multiple] [--shell-type [SHELL-TYPE]]

_occ_48ee92c85c317686_complete:local: not valid in this context: -x

And this in my bash (4.x) (already for sourcing the shell completion)

[mjob@wigrid server]$ eval $(./occ _completion --generate-hook)
bash: Syntaxfehler beim unerwarteten Wort `('
[mjob@wigrid server]$ source <(./occ _completion --generate-hook)
bash: compdef: Kommando nicht gefunden.

[nickvergessen]

I got a similar error just now, because an app required an update.
Will have a look if we can add better error handling there...

[nickvergessen]

Fixed the issue @MorrisJobke

[MorrisJobke]

Rebased to fix the sign-off check issue

[MorrisJobke]

Tested and works now 👍

Sadly it only work for full path (/path/to/occ) and not for relative path (./occ)

[codecov-io]

Current coverage is 30.59% (diff: 0.00%)

Merging #1476 into master will decrease coverage by 0.08%

@@             master      #1476   diff @@
==========================================
  Files          1080       1082     +2   
  Lines         59885      60059   +174   
  Methods        6775       6810    +35   
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          18375      18375          
- Misses        41510      41684   +174   
  Partials          0          0          

Diff Coverage	File Path
0%	core/Command/App/CheckCode.php
0%	core/Command/TwoFactorAuth/Disable.php
0%	core/Command/App/ListApps.php
0%	core/Command/Log/File.php
0%	new core/Command/Config/App/Base.php
0%	core/register_command.php
0%	core/Command/App/Disable.php
0%	core/Command/TwoFactorAuth/Enable.php
0%	lib/private/Console/Application.php
0%	core/Command/L10n/CreateJs.php

Review all 27 files changed

Powered by Codecov. Last update 8a14f4a...6188955

[nickvergessen]

@MorrisJobke works for relative paths here as well. I guess you just need to generate it twice:

eval $(/var/www/nextcloud/occ _completion --generate-hook)
eval $(./occ _completion --generate-hook)

Just tested and confirmed.