Return 404 on v2.php when the app is disabled #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MorrisJobke, @LukasReschke and @bartv2 to be potential reviewers |
|
looks ok 👍 |
MorrisJobke
requested changes
Sep 22, 2016
| @@ -37,7 +37,7 @@ public static function notFound() { | |||
| $format = \OC::$server->getRequest()->getParam('format', 'xml'); | |||
| $txt='Invalid query, please check the syntax. API specifications are here:' | |||
| .' http://www.freedesktop.org/wiki/Specifications/open-collaboration-services. DEBUG OUTPUT:'."\n"; | |||
| OC_API::respond(new OC_OCS_Result(null, API::RESPOND_UNKNOWN_ERROR, $txt), $format); | |||
| OC_API::respond(new OC_OCS_Result(null, API::RESPOND_NOT_FOUND, $txt), $format); | |||
There was a problem hiding this comment.
Really? Should it not be a Method not allowed response? Because the endpoint is not found and not the actual entity.
There was a problem hiding this comment.
That OCS code does not exist...
|
@MorrisJobke can we move this forward? |
MorrisJobke
approved these changes
Sep 27, 2016
|
👍 |
This was referenced Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when testing nextcloud/notifications#23
Not found should obviously return with "404" and not with "500"