Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OC host/port/protocol helpers to the bundle and deprecate them #15520

Merged
merged 1 commit into from May 14, 2019

Conversation

ChristophWurst
Copy link
Member

They are pretty useless. If an app wants to mock that it can provide their own abstractions.

@ChristophWurst ChristophWurst added this to the Nextcloud 17 milestone May 13, 2019
@ChristophWurst ChristophWurst self-assigned this May 13, 2019
@ChristophWurst ChristophWurst added this to TO REVIEW (max 4 PRs) in Christoph's Tasks via automation May 13, 2019
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

Christoph's Tasks automation moved this from TO REVIEW (max 4 PRs) to TO INTEGRATE May 13, 2019
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 13, 2019
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the refactor/oc-host-port-protocol-bundle branch from 933de7b to 9aeed85 Compare May 14, 2019 06:37
@ChristophWurst ChristophWurst merged commit b6c6be6 into master May 14, 2019
Christoph's Tasks automation moved this from TO INTEGRATE to DONE May 14, 2019
@ChristophWurst ChristophWurst deleted the refactor/oc-host-port-protocol-bundle branch May 14, 2019 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants