Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid scrolling to the hidden input when toggling grid/list view #16005

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Avoid scrolling to the hidden input when toggling grid/list view #16005

merged 1 commit into from
Jun 19, 2019

Conversation

juliushaertl
Copy link
Member

Steps to reproduce:

  • Have a folder with many files
  • Scroll to the bottom
  • Switch between grid/list view

Expected behavior:

  • The scroll position remains

Actual behavior:

  • The browser scrolls back to the top

Fixes #16002

@juliushaertl
Avoid scrolling to the hidden input when toggling grid/list view
25a646e 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added this to the Nextcloud 17 milestone Jun 19, 2019
@juliushaertl
Copy link
Member Author

/backport to stable16

@juliushaertl
Copy link
Member Author

/backport to stable15

@skjnldsv
Copy link
Member 


There was 1 failure:
--
97 |  
98 | 1) Test\Files\ViewTest::testDeleteGhostFolder
99 | Failed asserting that '5d09e74b055d0' is not equal to "5d09e74b055d0".
100 |  
101 | /drone/src/tests/lib/Files/ViewTest.php:2596

Not related, though we should fix it! Can anyone tackle this?

@skjnldsv skjnldsv merged commit abb1fd9 into master Jun 19, 2019
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 19, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable16 in #16007

@skjnldsv skjnldsv deleted the bugfix/16002/grid-toggle-scroll branch June 19, 2019 08:50
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 19, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #16008

@skjnldsv
Copy link
Member

This created a regression.
Because it's hidden, it cannot be focused via keyboard anymore now :)

@skjnldsv
Copy link
Member

See #16154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@GretaD GretaD Awaiting requested review from GretaD

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.

Switching between list and grid view scrolls back to the top
3 participants
@juliushaertl @skjnldsv @ChristophWurst