Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix size of header menus #16057

Merged
merged 3 commits into from
Dec 7, 2019
Merged

Fix size of header menus #16057

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6283b57
Fix size of header menus
juliushaertl Jun 24, 2019
d889019
Fix horizontal scrollbar in user menu
jancborchardt Jun 24, 2019
bef426e
Move to proper scroll container and add more space to height
juliushaertl Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions core/css/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,12 @@
z-index: 2000;
position: absolute;
max-width: 350px;
max-height: $header-menu-entry-height * 7.5; // half entry
min-height: calc(44px * 1.5); // show at least 1.5 entries
max-height: calc(100vh - #{$header-height} * 2);
right: 5px; // relative to parent
top: $header-height;
margin: 0;
overflow-y: scroll;
-webkit-overflow-scrolling: touch;

&:not(.popovermenu) {
Expand All @@ -112,7 +114,7 @@

/* Use by the apps menu and the settings right menu */
#apps > ul,
&.settings-menu > ul {
&.settings-menu {
li {
a {
display: inline-flex;
Expand Down Expand Up @@ -318,13 +320,6 @@ nav[role='navigation'] {
}
}

#apps {
max-height: inherit;
overflow-x: hidden;
overflow-y: auto;
-webkit-overflow-scrolling: touch;
}

/* USER MENU -----------------------------------------------------------------*/
#settings {
display: inline-block;
Expand Down