Add tab if alternate login present

[ochorocho]

Recently installed Nextcloud for roughly 40 users. Users are supposed to login using Gitlab login provided by sociallogin app.

Not even half of the users noticed the "Alternate Login" button. Therefore i created a tab menu for login. I also introduced a setting in admin area to force alternate login as "active" tab.

When no alternate login is available:

[rullzer]

Could you rebase your PR ;)
As 12010 files changes seems a tad much 😉

[ochorocho]

Could you rebase your PR ;)
As 12010 files changes seems a tad much 😉

Tbh, was late yesterday and i screwed it up while signing my commits...

@rullzer do you like the idea?

You can test it here: https://nextcloud.knallimall.org/

[rullzer]

I'm fine but I'd like the JS experts and designers to have a look ;)

[kesselb]

I'm not a fan. I think we should improve the visibility of the alternative logins instead of adding a new visual element (which is not used anywhere else in nextcloud). For example the stackoverflows login screen looks very clean.

[splitt3r]

Off topic: @ochorocho Awesome that you contribute to GitLab and now Nextcloud 😍 Great work!

[jancborchardt]

Good initiative @ochorocho!

Agree with @kesselb here that instead of making the design more complex, the other logins should be made more present by being moved up like on other platforms. :)

Then not even an extra admin setting to set the active tab is necessary because there are no tabs. Easier for everyone. :)

[ochorocho]

Ok :-) Still like the tab view thing.
Created a little theme which does what i need, see https://github.com/ochorocho/nextcloud-theme-tablogin

Works with NC 16 and NC 17 (current master)

[jancborchardt]

@ochorocho @kesselb would someone of you be up to change it as @kesselb described? Would certainly be good to fix this in core and not just as a theme. :)

[kesselb]

Adding a logo and another color seems to be more complicated. I think this information should be provided by https://github.com/zorn-v/nextcloud-social-login and passed as additional data (e.g. a logo) to

server/lib/private/legacy/app.php

Lines 648 to 650 in 810ee7d

	public static function registerLogIn(array $entry) {
	self::$altLogin[] = $entry;
	}

As a start we should set a custom class to <li> based on the name or href to apply custom styles more easily.

server/core/templates/login.php

Lines 11 to 13 in 64c4bb5

	<?php foreach($_['alt_login'] as $login): ?>
	<li><a class="button" href="<?php print_unescaped($login['href']); ?>" ><?php p($login['name']); ?></a></li>
	<?php endforeach; ?>

[ochorocho]

@jancborchardt just moved the buttons above the form and optimized alignment of the buttons

See https://nextcloud.knallimall.org/

[kesselb]

I would suggest to add "log in with" to make the purpose of the button more clear. <?php p($l->t('Log in with')) ?>.

[kesselb]

https://github.com/zorn-v/nextcloud-social-login/blob/master/css/style.css Hmm. There is already a style sheet with logos for github.

[ochorocho]

Yes, only for the pre-defined oauth provider but not for "OpenID Connect/Custom OpenID Connect"

[jancborchardt]

Great stuff @ochorocho!
Agree with adding the "Log in with …" before the provider that @kesselb mentioned. Also, right now it’s a bit confusing cause there are 3 primary buttons:

• The buttons should be colored according to the provider. Google red, Twitter light blue, Facebook dark blue, GitLab dark purple, GitHub dark grey etc.
• Also I would add icons (monochrome, that is only white) to the left inside the icons for better recognition, as this is also standard for "Log in with" buttons. We have some of these icons already in https://github.com/nextcloud/server/tree/master/core/img (like twitter.svg)
• There should be a tiny bit more whitespace between the log in buttons and the form for username and password, just for visual separation.

Then I think it would be super.

[ochorocho]

@jancborchardt @kesselb this is what i'm going to do.

Todo Nextcloud

• More space between login buttons and form

Todo in Social login

• Color Buttons
• Add predefined icons (monochrom)
• Add "Login in with"

[jancborchardt]

Yup, sounds great @ochorocho! :) Thanks a lot.

And maybe with the visual changes to the buttons it’s also fine to put them below the "Log in" button again. So like:

[       Username      ]
[       Password      ]
(       Log in →      )
          or
( Log in with Google  )
( Log in with GitHub  )

[ochorocho]

This is how it will like now...
Still need open a pr for the sociallogin repo.

[skjnldsv]

I guess no one will have that many, right? ^^'

[ochorocho]

@zorn-v Yep, another idea would be to remove "Log in with" on small viewports.

[zorn-v]

I think it is good compromise

[zorn-v]

What color would you suggest as "not blue" ? :-)

I think someting like border: 0 or border-color for colored buttons. Blue buttons for alternative logins without borders may be unnoticeable I think.

[jancborchardt]

What color would you suggest as "not blue" ? :-)

Simply the class="primary" needs to be removed from the button, then it should work. :)

[ochorocho]

@jancborchardt @zorn-v

• removed class primary , after that registration buttone was white background with white text, so i changed the text-color to blue.
• Removed "Log in with" on small viewports (< 1024px)
• min-width was set to align width to "Log in"-Button, if more space needed it will take up to 400px

[jancborchardt]

Super impressive work @ochorocho! Looks perfect now 🚀

Please review too @nextcloud/designers :)

[jancborchardt]

Oh just saw the:

Removed "Log in with" on small viewports (< 1024px)

I would say this makes it confusing. I’d rather say cut the icon on mobile, or ellipsize. But the label needs to be explanatory. Otherwise it’s like "Google? What, is that a link to the service?"

(also small typo: It’s "Salesforce" not "Saleforce", not sure in which component that is. :)

[ochorocho]

@jancborchardt only icons hidden on small devices now...

[kesselb]

Thank you @ochorocho for this great contribution 🎉 and also thanks to @zorn-v for your feedback over here 👍

[ochorocho]

I thinks this is ready now :-)

[skjnldsv]

This could lead to issues in other layouts, but we'll have a look later I guess, since we're at the start of 18!

[skjnldsv]

A few unrelated failures :)
Merging!

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!