-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eslint global nextcloud config #17263
Conversation
so. It all looks sane. I'm just afraid to press approve on such a huge PR... |
Just for curiosity: Is it really necessary to remove all semicolons? I know nearly no guide, which recommends automatic semicolon insertion (ASI). I looked up Google, AirBNB, W3 School, Mozilla. Only StandardJS does. Even the Nextcloud docs says: |
@go2sh that's a very long debate :p In the end, to quote someone: "Discussing about it is opinionated and will induce an endless debate which is not what we want." 😉 |
2126057
to
1154a6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files like settings/js/vue-settings-apps-users-management.js
have like 25k lines added. Did you compile in dev mode? The bundles should not change their size actually.
I don't think so! 🤔 EDIT: yes it is :) |
@skjnldsv i dont want to start a discussion. I just thought semicolon was the way to go in nextcloud |
1154a6a
to
ecd9c4e
Compare
Bump! I'd like to quickly get this so I don't have to rebase crazy things and also we can catch stuff early for 18 :) |
Well I guess we should just rebase and instant merge this |
let me rebase one last time then |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
ecd9c4e
to
b9bc241
Compare
All rebased! |
While understandable for this one since it would be very wasteful to keep re-basing a change like this, I'd like to ask that merging without reviews not become a pattern. Especially for changes as large as this one. |
Surely not becoming a pattern 👍 |
Waiting for @GretaD's pr in Move users management to multi line #17239Crazy lots of cleanup! 😑
I found some prettu weird code out there. 🙈
Lots of cleanup left to do, but will be in a follow-up
/**
but/*